Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1229287ybk; Thu, 21 May 2020 01:43:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzaVM2cBzVCZsRJu0wLHhaSE88yExwPTI0n3vCB0721fE1dhUozDQiUUExyEzv8VnmUHzGZ X-Received: by 2002:a17:906:298a:: with SMTP id x10mr2405955eje.238.1590050583469; Thu, 21 May 2020 01:43:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590050583; cv=none; d=google.com; s=arc-20160816; b=Fb21q49obokcik+vWdZ0jMcXM9WB+MgqJWltrBz42XUcQgMcRSXfppo5hbE4bQaqPe frqjD6P3tYTXqeCiRg2wQhANNF5wzPDK+ZJHs7vynhX99jdZU5GZoyPcFqSWdgCLW2w9 we/sivDBvhSlaGOQuvaYmZfCJy7k1Tg3DvF4/szPIk9FTJ5YGXVYS5wKcE+Jhzly5dsE TaVtKteDiVFE5jgME1239X82fpgV28RA/U7gjhQFJB89TA23eGoQccY/5doWddMTAnu6 sHQKcUx7vOSg+iB74zMHUBOkpx4WB5CupttloAUrR6fMPuM+zG5l7PJ3/gUd7qEnkQp1 vqBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=3kiiTlaMwIl14kIUOW6SCc88+ZdFyNZFrF9UArLnn6M=; b=xFWt0q8d/YuCu0DgSC4JAHn0l2G2kI9cmANtJY0RmbympgK0nylxvtRkRo6oQ7MMaL kSiXrED/rWYUo0dNJ12k4CmdI1JgBKgoUJtehpb/xeKmJdBy2lnsBpmaHiZY4wH8W86y eGN3S+KE8NP2DfMb6UFix4XeCeyJyp2OpTn/ihJQlroA9HICU4ws39tFMqeeBnAL94JD hkuJmQkx43PqkReSNomrGa9xXiki7l9poSdWiR0CgxCLPbanAdtwkK7ZWy/AafZJrEUj F1BOil9g5PhnX5zoX10fNYaSiUxlzw4higBWCaeMxSSxHBnrgBY7C8+O2fbfbssoePdX stkg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ov4si3044609ejb.237.2020.05.21.01.42.39; Thu, 21 May 2020 01:43:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728717AbgEUIkz (ORCPT + 99 others); Thu, 21 May 2020 04:40:55 -0400 Received: from mx2.suse.de ([195.135.220.15]:59810 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728635AbgEUIkz (ORCPT ); Thu, 21 May 2020 04:40:55 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 5B0F2AE89; Thu, 21 May 2020 08:40:56 +0000 (UTC) Date: Thu, 21 May 2020 10:40:52 +0200 From: Petr Mladek To: Brendan Higgins Cc: Andy Shevchenko , Greg KH , "Rafael J. Wysocki" , Linux Kernel Mailing List , David Gow , Heidi Fahim , Heikki Krogerus , Hans de Goede , "Rafael J . Wysocki" , Sakari Ailus , Rob Herring Subject: Re: [PATCH v1] Revert "software node: Simplify software_node_release() function" Message-ID: <20200521084052.GF3464@linux-b0ei> References: <20200228000001.240428-1-brendanhiggins@google.com> <20200520150227.GA8397@linux-b0ei> <20200520164156.GA1634618@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2020-05-20 11:21:49, Brendan Higgins wrote: > On Wed, May 20, 2020 at 9:42 AM Andy Shevchenko > wrote: > > > > On Wed, May 20, 2020 at 05:02:27PM +0200, Petr Mladek wrote: > > > On Thu 2020-02-27 16:00:01, Brendan Higgins wrote: > > > > > I have found similar report from a test robot, see > > > https://lore.kernel.org/lkml/20200303002816.GW6548@shao2-debian/ > > > > > > > > > I was staring into it for a while and do not understand it. The revert > > > makes sense. I wonder if it somehow changes the order in which > > > the release methods are called. > > > > > > Anyway, reverting the revert makes test_printf working. > > > > There is a proper fix IIRC from Heikki in driver core (no link at hand, sorry). > > The fix for this patch can be found here: https://lkml.org/lkml/2020/5/13/1070 Thanks for hint. This patch helped. Best Regards, Petr