Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1232220ybk; Thu, 21 May 2020 01:48:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTfxe9lT1R4fQgtWmkRRH0+0H0aRxOYpUcV4n82zsIEIMhqHiGNubOwyTwtii7pMsKXfLN X-Received: by 2002:a05:6402:2c3:: with SMTP id b3mr7285820edx.66.1590050920653; Thu, 21 May 2020 01:48:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590050920; cv=none; d=google.com; s=arc-20160816; b=GQ3ULI511iPppEn3NMhmWtMVK7Ktb60Q6Gm9lDb3lCXf8h8BC9X15zZpohgwnh2i0Y eqrrkKbr91kkDUjNVchmjKQF8nVzXzTl2oMx+lhN3P6JOHqoRSLFnRc8Bw9LBPr53Fl1 bdFFW7Qm+W3MgVnXvzT5Ab4VvruJ5vCniS8Nl8218cSCxfY+EYvr1YV6gLy2P9XgSXbv +SzTKdjAAZ600sPbOh8FdevdPIVhX+GGfCHDmzJd+tZ9JlQmmdRU9yN63x/T6YxVIPhL 5YzFBfJlmzlef5Mjlegnp2s/lI6RpU7cn+SY/FCZH66VIT/gdt8NNF+MQjJfhRUpZeha /VEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject; bh=wqcKSIH4pp4cK2tXITvJHzUw6hoJbcNsCjS4/KGudkE=; b=ponle8XE2dQb2FLD6Ryrs6dURaC8XLO5OlYay0FZE3nJmz6YBLaOMCMBXej+Ylp9u5 IledeBNlRL8YlBNz8/9BBEB58KpdFE8M5L/ReNSRttisbb5skIDLc5m3qPhEcYVBMnNC zdc1r3++AqUrRWnSEfVNnTdPdBWYsxNMIO50/teHYOJjSfwG80IYKSQbBrE9dhumBpAq waRq7wtCK1qLwivErOOtcvFdI2nZTIJQIn90BqRvJw9P5EL3to3/W4bnKDAO8vWjvmmd mHFhllYdmAcIxCt2pu15cVGAJeINdn4sUJIGZ8XozbNt/RZ8Pl9NhY+p6l9Sz+YjRrKt EwuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b="EK/aTQ7r"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h12si2958336ejq.371.2020.05.21.01.48.16; Thu, 21 May 2020 01:48:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b="EK/aTQ7r"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728673AbgEUIqy (ORCPT + 99 others); Thu, 21 May 2020 04:46:54 -0400 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:8370 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728561AbgEUIqx (ORCPT ); Thu, 21 May 2020 04:46:53 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 21 May 2020 01:44:28 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 21 May 2020 01:46:52 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 21 May 2020 01:46:52 -0700 Received: from [10.26.75.55] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 21 May 2020 08:46:50 +0000 Subject: Re: [PATCH] spi: tegra20-slink: Fix runtime PM imbalance on error From: Jon Hunter To: Andy Shevchenko , Dinghao Liu CC: Kangjie Lu , Laxman Dewangan , "Mark Brown" , Thierry Reding , linux-spi , , "Linux Kernel Mailing List" References: <20200521074946.21799-1-dinghao.liu@zju.edu.cn>

Message-ID: <046fe754-96d7-4530-2b70-e1991470ac0f@nvidia.com> Date: Thu, 21 May 2020 09:46:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1590050668; bh=wqcKSIH4pp4cK2tXITvJHzUw6hoJbcNsCjS4/KGudkE=; h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=EK/aTQ7rz3fHlcaD5IK88IPRC9F2WKPnEk8U1kjY3eUJ4aVxQTGjZo8exZK1UGoDT VSL+iaoWOySo0FaGcLWp86UMMte8DBPPK90bzFD/NMty64vc2bhrqjXh5Y7qSoXIdD 41k9xImeVn4R27lKhd48Egf3OAYlUJHWwZMaCn43XRITX4cqt5MjJ/vTxmqFDfe2jr /RwzeaVbMUcf8Igx8//gLJKvYWjb8bzkozqazOjq14y1KIFUxHb4HXSN8eElcOxesq IYBSKjlRqZnSYPxtrDH+DHZAa+eriiHszqof61od+tMtBkm4/Of5zi4P2LezBBAGEv vrXwXg/pZ6PvA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/05/2020 09:38, Jon Hunter wrote: > > On 21/05/2020 09:04, Andy Shevchenko wrote: >> On Thu, May 21, 2020 at 10:50 AM Dinghao Liu wrote: >>> >>> pm_runtime_get_sync() increments the runtime PM usage counter even >>> when it returns an error code. Thus a pairing decrement is needed on >>> the error handling path to keep the counter balanced. >> >> ... >> >>> ret = pm_runtime_get_sync(&pdev->dev); >>> if (ret < 0) { >>> dev_err(&pdev->dev, "pm runtime get failed, e = %d\n", ret); >> >>> + pm_runtime_put(&pdev->dev); >> >> For all your patches, please, double check what you are proposing. >> >> Here, I believe, the correct one will be _put_noidle(). >> >> AFAIU you are not supposed to actually suspend the device in case of error. >> But I might be mistaken, thus see above. >> >>> goto exit_pm_disable; >>> } > > > Is there any reason why this is not handled in pm_runtime_get itself? Ah I see a response from Rafael here: https://lkml.org/lkml/2020/5/20/1100 OK so this is intentional and needs to be fixed. Jon -- nvpublic