Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1233926ybk; Thu, 21 May 2020 01:51:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9s1giPeKT03zqSF/bixlDggow5t4M07tgjxHRD4qx9o02B81o2RY2p21r++R866DlfN77 X-Received: by 2002:a50:fd99:: with SMTP id o25mr6656313edt.98.1590051106196; Thu, 21 May 2020 01:51:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590051106; cv=none; d=google.com; s=arc-20160816; b=WFiiF+O0ccf7Knjep+oFWv+xltaBMoggN5GTcvpDbRp1IW6uzdniBgKoeIOZrpEYsK hMounXMza6NPrDclKWv6Jsk22qHwH/s55oO9qsbswFmQOeHs2fxpaN01hii5btLVg6Hn Zr7BYnBL8f3ttD7lkF9/XH3I84w7SGThceqOsqYXlYEOB0tYNDQwttg5Qsr8C4dhsdu1 5KJJA/6wigfX2ZLdCvpO0JSJVLv4hxrmpq/5qLcXyhTGGGm0DGGQJ+oEKcOjnLP8Rhc3 4bh8DmOPaekenSht5zDGExkdkiorjT/Cyc/PHzw7r/gRIHa8dHxZdnflAuiKJokEgmaC vXFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=v8vlmskCHrKeTXyyWmx+gVG4HuDCFbjKVh3rj+1IeFY=; b=WUUdurxWNk7AN5ZR1ipUpzGhKtIt4Lo8RvlqcpT6yDOfDpDbIu1iUzD/ykt5yeaAOI i5G4+pPeP+OvaYNuhy0cT4l0aZ7/aGFE29Cu1v++5KGo/JmlPuflrARayYVKr6SRf/D9 I8RzrB2liI4vU5oXbqfvJlt+L1EdSvYeocCQMQ69sAi5GFh5WsznyDHruvmMF2/pIVLK +vgrLSPf4UJc5wEi2m7qoNTzs/whjt3aGk0sG2JrhsQgdlKWPprPQZlrWCVPDmMt2dWU jmGOQ2qVhLF5vPwWR9BE6eMTr0C0femt+hapWUB/YfOSQo+VVv4HyO7XGwozLs56oMlm rkwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r20si1322593ejj.464.2020.05.21.01.51.23; Thu, 21 May 2020 01:51:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728719AbgEUIrr (ORCPT + 99 others); Thu, 21 May 2020 04:47:47 -0400 Received: from mailomta2-re.btinternet.com ([213.120.69.95]:43339 "EHLO re-prd-fep-044.btinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728623AbgEUIrr (ORCPT ); Thu, 21 May 2020 04:47:47 -0400 Received: from re-prd-rgout-001.btmx-prd.synchronoss.net ([10.2.54.4]) by re-prd-fep-044.btinternet.com with ESMTP id <20200521084744.KRVR4009.re-prd-fep-044.btinternet.com@re-prd-rgout-001.btmx-prd.synchronoss.net>; Thu, 21 May 2020 09:47:44 +0100 Authentication-Results: btinternet.com; auth=pass (LOGIN) smtp.auth=j.oldman998@btinternet.com X-Originating-IP: [31.53.141.224] X-OWM-Source-IP: 31.53.141.224 (GB) X-OWM-Env-Sender: j.oldman998@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgeduhedrudduuddgtdejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecunecujfgurhephffvufffkffosedttdertdertddtnecuhfhrohhmpeflohhhnhcuqfhlughmrghnuceojhhohhhnrdholhgumhgrnhesphholhgvhhhilhhlrdgtohdruhhkqeenucggtffrrghtthgvrhhnpeegfedthfefueeihffgkeefteehuddttdefudetveelveefvdefhfejieejhffggfenucfkphepfedurdehfedrudeguddrvddvgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopehhvghnrhihrdhhohhmvgdpihhnvghtpeefuddrheefrddugedurddvvdegpdhmrghilhhfrhhomhepoehjohhhnhdrohhlughmrghnsehpohhlvghhihhllhdrtghordhukheqpdhrtghpthhtohepoeguvghvvghlsegurhhivhgvrhguvghvrdhoshhuohhslhdrohhrgheqpdhrtghpthhtohepoehgrhgvghhkhheslhhinhhugihfohhunhgurghtihhonhdrohhrgheqpdhrtghpthhtohepoehjohhhnhdrohhlughmrghnsehpohhlvghhihhllhdrtghordhukheqpdhrtghpthhtohepoehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgheq X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from henry.home (31.53.141.224) by re-prd-rgout-001.btmx-prd.synchronoss.net (5.8.340) (authenticated as j.oldman998@btinternet.com) id 5E3A147D11B190C7; Thu, 21 May 2020 09:47:44 +0100 From: John Oldman To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, John Oldman Subject: [PATCH] staging: rtl8192e: Using comparison to true is error prone Date: Thu, 21 May 2020 09:47:32 +0100 Message-Id: <20200521084732.12576-1-john.oldman@polehill.co.uk> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clear below issues reported by checkpatch.pl: CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c index 43494a2b6f05..462835684e8b 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -456,7 +456,7 @@ static void _rtl92e_dm_bandwidth_autoswitch(struct net_device *dev) if (priv->CurrentChannelBW == HT_CHANNEL_WIDTH_20 || !priv->rtllib->bandwidth_auto_switch.bautoswitch_enable) return; - if (priv->rtllib->bandwidth_auto_switch.bforced_tx20Mhz == false) { + if (!priv->rtllib->bandwidth_auto_switch.bforced_tx20Mhz) { if (priv->undecorated_smoothed_pwdb <= priv->rtllib->bandwidth_auto_switch.threshold_40Mhzto20Mhz) priv->rtllib->bandwidth_auto_switch.bforced_tx20Mhz = true; @@ -1297,7 +1297,7 @@ static void _rtl92e_dm_dig_init(struct net_device *dev) static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev) { - if (dm_digtable.dig_enable_flag == false) + if (!dm_digtable.dig_enable_flag) return; if (dm_digtable.dig_algorithm == DIG_ALGO_BY_FALSE_ALARM) @@ -1332,7 +1332,7 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_driver(struct net_device *dev) u8 i; static u8 fw_dig; - if (dm_digtable.dig_enable_flag == false) + if (!dm_digtable.dig_enable_flag) return; if (dm_digtable.dig_algorithm_switch) @@ -1366,7 +1366,7 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_false_alarm(struct net_device *dev) static u32 reset_cnt; u8 i; - if (dm_digtable.dig_enable_flag == false) + if (!dm_digtable.dig_enable_flag) return; if (dm_digtable.dig_algorithm_switch) { @@ -1501,7 +1501,7 @@ static void _rtl92e_dm_initial_gain(struct net_device *dev) reset_cnt = 0; } - if (rtllib_act_scanning(priv->rtllib, true) == true) { + if (rtllib_act_scanning(priv->rtllib, true)) { force_write = 1; return; } -- 2.17.1