Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752245AbWCPIUc (ORCPT ); Thu, 16 Mar 2006 03:20:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752249AbWCPIUb (ORCPT ); Thu, 16 Mar 2006 03:20:31 -0500 Received: from dsl027-180-168.sfo1.dsl.speakeasy.net ([216.27.180.168]:43674 "EHLO sunset.davemloft.net") by vger.kernel.org with ESMTP id S1752245AbWCPIUa (ORCPT ); Thu, 16 Mar 2006 03:20:30 -0500 Date: Thu, 16 Mar 2006 00:20:04 -0800 (PST) Message-Id: <20060316.002004.97779505.davem@davemloft.net> To: ioe-lkml@rameria.de Cc: yoshfuji@linux-ipv6.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] IPv6: Cleanups for net/ipv6/addrconf.c (kzalloc, early exit) v2 From: "David S. Miller" In-Reply-To: <200603102334.27590.ioe-lkml@rameria.de> References: <20060212.021103.76157181.yoshfuji@linux-ipv6.org> <20060310.030258.55767431.davem@davemloft.net> <200603102334.27590.ioe-lkml@rameria.de> X-Mailer: Mew version 4.2.53 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 736 Lines: 25 From: Ingo Oeser Date: Fri, 10 Mar 2006 23:34:26 +0100 > Here are some possible (and trivial) cleanups. > - use kzalloc() where possible > - invert allocation failure test like > if (object) { > /* Rest of function here */ > } > to > > if (object == NULL) > return NULL; > > /* Rest of function here */ > > Signed-off-by: Ingo Oeser > Acked-by: YOSHIFUJI Hideaki Applied, thanks a lot Ingo. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/