Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1264874ybk; Thu, 21 May 2020 02:41:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrFl6pAcOJRUlVIK/JNMyg1mhWtncuErWKMDiEp67osNxa4iIBPkjgi7UnhUEfFJ3Fl5A5 X-Received: by 2002:a50:f610:: with SMTP id c16mr7295145edn.175.1590054111557; Thu, 21 May 2020 02:41:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590054111; cv=none; d=google.com; s=arc-20160816; b=GffIhuOCh1BekWEqtajSAVjoV2FHeOJlTfN6K0SqLcIJuTecOs1EcrzwpZlG+nGMOM CH2uuAaumJJ7awgb2OcMHfoWmELhiFNdYVElXUvBhiYVwi4C5BkiUqLjqxsC3Aqpelze ekf6VsKlK5y+hD3L+BS3avk4As49CvX50a2NLE/mUrvIuzqxtk66H+9lVEewM2cD6wE6 FInKiTDRla1c5ffGt7PEH+4bQ9Pxz5Lli62ZDAgb1rggEgsPYzp7KeGrwvX6afq89r29 Q7mCVw3QB0mYfU5CLsAV9glGE9ZqX+7sxUqup1WWPY7XKbEEgySUF+x9V03fIQHtzFsT VNqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=XRRenhNm9RcrMGaLaFDRHCMDiaKFzvbNFCQExEVcZEI=; b=DAC6FJ3G7cAj/dA9GNRUWsCfdjKoli8edNssHXQoCGHf7/sNsf7LqdJZuCGqVHS9u2 sf5sBw4zT8vRuQbeiiuZKx1AvhHOLjhfFsjotLMrddsswrW5fsj9VkwS25L1amCIQmWn b/2438LUflSlPXEAPtsCKXn9eKmf+EnF4uIR0xhTDyzDm+rXOK7h4sg9GU4k0U1UlN2O +pAOfUBxQxPSUKAvmNUrpiz7hQ7V67iEdnu73n0F6BpnrTvNgo7foB3WDgKWvyikX7i7 rz3Bzlm7LsvE2qQ1HZv7s4VMYut9+9iI1X/EQi51bm0ClL7tJ6GBER39W6dTVEQig0xU QIOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=HmNGNwT0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lu5si2944351ejb.709.2020.05.21.02.41.29; Thu, 21 May 2020 02:41:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=HmNGNwT0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728917AbgEUJiI (ORCPT + 99 others); Thu, 21 May 2020 05:38:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728719AbgEUJiH (ORCPT ); Thu, 21 May 2020 05:38:07 -0400 Received: from mail-oo1-xc43.google.com (mail-oo1-xc43.google.com [IPv6:2607:f8b0:4864:20::c43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEACCC061A0E for ; Thu, 21 May 2020 02:38:07 -0700 (PDT) Received: by mail-oo1-xc43.google.com with SMTP id p67so1312427ooa.11 for ; Thu, 21 May 2020 02:38:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XRRenhNm9RcrMGaLaFDRHCMDiaKFzvbNFCQExEVcZEI=; b=HmNGNwT0/nTNwhk2QkQq2ieaY4fXPKzgGc6i93+BrNIwF1AtkKSu77TWtbfKwcwSc6 dT/v4sy6DWT5wDaNmoJdoIAMrvhkxh2HNpgz8Hc2Vmu48egXDLCOqlFeI1mXEjLC/rb+ APGPTYy2+DgT65Pc3waqCCRCvynp0Wbb3L5+UO+XfRz1RdirUXPJo9l8QPU4ylGmnxHp fJnleaCszpokXvQmkjyQuIjofri9zb8Pv2tjn3gaesbANbJzORgc/3wOTDWewar+37kF zlKDEVAHiOoKaaRAeVZZmW+ZKx7fqyCgVv6bS6xR9SGAr/PR/W8BIXM3MPItVGOW/6WM f72Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XRRenhNm9RcrMGaLaFDRHCMDiaKFzvbNFCQExEVcZEI=; b=U+wQ0bBD3F9MeaMYt9yx1zi7A0aXRD+GXv4wXvT+KT60Z0nnFkIg8T4Sn8fghIqfxD AR/8Qi3ZvaUhtV6QTDenTiYPoqFPuQjEXmjcoJ1WFSQRS2ZjWLlgIAb2UnmyAts1285G taSDHDm++VrxRAnEyhuiUMKsuw3mfh/e5OhF4uU8caRiTyxnRg694fHNbPaoUBPtjNN1 +zVTEp8r5e8iyshtne/Al2zAIM5obA1LG2iEk0Fka8VPOeAJIx+Vt34IsMnuxY2oxZ4d 9SSyTzc9+lAN667s7z5GllrTViEnTrVtYD0ZpyU6cwpEXWR/iJSUCFq0A5LP1hbHTm5H 69ww== X-Gm-Message-State: AOAM530voA3aRpqctUYOk8DY+dbO/bXk9NsbWqxL9r5P3H1fwz+Tp/5t 5v40YZ/8R9o9NSb7K2sXf+GWSGMIwycBSDIYnsfYog== X-Received: by 2002:a4a:e836:: with SMTP id d22mr6691371ood.54.1590053886935; Thu, 21 May 2020 02:38:06 -0700 (PDT) MIME-Version: 1.0 References: <20200511204150.27858-18-will@kernel.org> <158929421358.390.2138794300247844367.tip-bot2@tip-bot2> <20200520221712.GA21166@zn.tnic> <20200521072557.GA10099@zn.tnic> In-Reply-To: <20200521072557.GA10099@zn.tnic> From: Marco Elver Date: Thu, 21 May 2020 11:37:54 +0200 Message-ID: Subject: Re: [tip: locking/kcsan] READ_ONCE: Use data_race() to avoid KCSAN instrumentation To: Borislav Petkov Cc: Will Deacon , "Peter Zijlstra (Intel)" , LKML , linux-tip-commits@vger.kernel.org, Thomas Gleixner , x86 Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 May 2020 at 09:26, Borislav Petkov wrote: > > On Thu, May 21, 2020 at 12:30:39AM +0200, Marco Elver wrote: > > This should be fixed when the series that includes this commit is applied: > > https://lore.kernel.org/lkml/20200515150338.190344-9-elver@google.com/ > > Yap, that fixes it. > > Thx. Thanks for confirming. I think Peter also mentioned that nested statement expressions caused issues. This probably also means we shouldn't have a nested "data_race()" macro, to avoid any kind of nested statement expressions where possible. I will send a v2 of the above series to add that patch. Thanks, -- Marco