Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1276959ybk; Thu, 21 May 2020 03:02:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVnfwDyDvY0eEsyTqdKYzhuQ1hZC+ZCFHjJKuA7gnI2QtoBfO9fdw/QaQOopU3aacfMdzx X-Received: by 2002:a50:da06:: with SMTP id z6mr6907889edj.372.1590055366086; Thu, 21 May 2020 03:02:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590055366; cv=none; d=google.com; s=arc-20160816; b=d20q8Dq9UEVzQn/wJbwzKaTxvxMrYmBIOeh2Zi0LlsqNsTdmmWPY+O1FRGj7M8Z+1Z o9c4KSE5I/PIYUvApY3eJdXCKaLp30K8X0OSpSMjx9AJB3DGk+/o8yk90bhx1RxtdXwV NxPb6gqn3clLh3BLb+EK5rL2Zq6wss2MUKP2zX3L1KSOsse8Kt8uzhXJX00kZwgPRPfk WzvbV3LjBlDljuDDiOxe5PaOhGZFLIDq17MBjrmSDva+pkuG7vAkVmSqKbS4liZ6C0Rm +JkMOL6BBF3gNT6j6tvSzqnekRiSa1rxH1C8FXZwJCogo0Enz+/mSs2g9Yn3U1WQ5P3S EQLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=mopS8h/CsB6XzyZ4sxdq0VL/p2xT/X9+l+Vyi7Psmxc=; b=EhueOy0lb4grShRwjrOBssh1fd/662Wwt2uWDdtJ5pKfAzC478AAXW8M5mqAnzbiJu vxRJARl0XKQGX5Q+b4s5LDhK2SkMxUl2/iGW2KRbgI969KMp/vy0P2oii+El1Va1Wj5e +GJuEVa+lYwGDdFrxMQbS37HFMfzGBD+M6JkkVpTMnSeXKwiJ9eWtQFV3tDlPtr6AfjJ ChUkhKOBYPNDW2DZ3GHk19m24a4fZ/yivoEi6LtzRt7XZKo1+G9rT//wEPZb14vzIPlB ejYQ4uCxb+4+xKcRSaRbayriFSSjTRFiNV6Qc0fRS9n2csEqonYyGUCgWJkX+rB2oPDL TT7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e5si3277080eje.518.2020.05.21.03.02.21; Thu, 21 May 2020 03:02:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727823AbgEUKAk (ORCPT + 99 others); Thu, 21 May 2020 06:00:40 -0400 Received: from mail.zju.edu.cn ([61.164.42.155]:61998 "EHLO zju.edu.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726405AbgEUKAj (ORCPT ); Thu, 21 May 2020 06:00:39 -0400 Received: from localhost.localdomain (unknown [222.205.77.158]) by mail-app4 (Coremail) with SMTP id cS_KCgCnsD02UcZee57rAQ--.40747S4; Thu, 21 May 2020 18:00:25 +0800 (CST) From: Dinghao Liu To: dinghao.liu@zju.edu.cn, kjlu@umn.edu Cc: Fabien Dessenne , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: bdisp: Fix runtime PM imbalance on error Date: Thu, 21 May 2020 18:00:21 +0800 Message-Id: <20200521100021.12461-1-dinghao.liu@zju.edu.cn> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: cS_KCgCnsD02UcZee57rAQ--.40747S4 X-Coremail-Antispam: 1UD129KBjvdXoWrKrW7ZFW3Gr18JF1xWF4UArb_yoWkWFg_Ww nrZFsrWr1Fkr1qqr1Utw13ZFyxXrZ8WF1rWa1SqFW2qayUZF13XrWUZF9rAws8Za1Fva47 trZ0gryIkrZ8ujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbIxFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AK wVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20x vE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4UJVW0owA2z4x0Y4vEx4A2 jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52 x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWU GwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI4 8JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY02Avz4vE14v_Gw1l42xK82IYc2Ij64vIr41l 42xK82IY6x8ErcxFaVAv8VW8uw4UJr1UMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I 8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWU twCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x 0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv67AK xVW8JVWxJwCI42IY6I8E87Iv6xkF7I0E14v26r4UJVWxJrUvcSsGvfC2KfnxnUUI43ZEXa 7VUb8hL5UUUUU== X-CM-SenderInfo: qrrzjiaqtzq6lmxovvfxof0/1tbiAgEHBlZdtOPItAAhsD Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c index af2d5eb782ce..e1d150584bdc 100644 --- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c +++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c @@ -1371,7 +1371,7 @@ static int bdisp_probe(struct platform_device *pdev) ret = pm_runtime_get_sync(dev); if (ret < 0) { dev_err(dev, "failed to set PM\n"); - goto err_dbg; + goto err_pm; } /* Filters */ @@ -1399,7 +1399,6 @@ static int bdisp_probe(struct platform_device *pdev) bdisp_hw_free_filters(bdisp->dev); err_pm: pm_runtime_put(dev); -err_dbg: bdisp_debugfs_remove(bdisp); err_v4l2: v4l2_device_unregister(&bdisp->v4l2_dev); -- 2.17.1