Date: Thu, 16 Mar 2006 00:38:19 -0800 (PST)
Message-Id: <20060316.003819.74819074.davem@davemloft.net>
To: adobriyan@gmail.com
Cc: eugene.teo@eugeneteo.net, linux-kernel@vger.kernel.org,
       thomas@x-berg.in-berlin.de, ralf@linux-mips.org, hans@esrac.ele.tue.nl
Subject: Re: [PATCH] Hamradio: Fix a NULL pointer dereference in
 net/hamradio/mkiss.c
From: "David S. Miller" <davem@davemloft.net>
In-Reply-To: <20060316082413.GA7789@mipter.zuzino.mipt.ru>
References: <20060316064211.GA22681@eugeneteo.net>
	<20060316070737.GA22920@eugeneteo.net>
	<20060316082413.GA7789@mipter.zuzino.mipt.ru>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 639
Lines: 18

From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Thu, 16 Mar 2006 11:24:13 +0300

> Actual codepath, please... valid "ax" is plonked into ->disc_data in
> mkiss_open().

Please be more clear about what you are advocating.
I had to sit and think about what you were saying
before I could figure out that you were actually
suggesting that the NULL check need not be there to
begin with.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/