Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1372576ybk; Thu, 21 May 2020 05:28:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz09LdRpTHSYO2BuO2FRz9t3d9SNDo02163PlPQRlBOEhdPYaOt2YLmAf62fxQJmLUrThhw X-Received: by 2002:a17:906:8043:: with SMTP id x3mr3405128ejw.390.1590064130049; Thu, 21 May 2020 05:28:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590064130; cv=none; d=google.com; s=arc-20160816; b=NX5oo9R/4XV2PTKA3R4j5rLsdZbj/0jqbzcCdpzePkgDlpva8dZRVdvauoufUiRbwm fmbuwhgYx2+CXCi91lfVuu2hUB/n4n+ZBTRpsQ6tfLDT1kj2Hco0yFM8GOdRjFFmJSXs jZ20rzYkUZYiPKn2oIk5pOKzpJzmuOXahmfIlsh1wewUe/vm5trr2VooS6nDVC9fTgwj 98fPxxr8NEJ7F0xBlVQn851YbmefJ7/uEkG52jC+U/RJQMf5h4Uk+dpJpMzu48PFfEJ+ wkgeLk5GO/QoFQ/xa5dm03AaxUao8b//q4KUBOyLjqa2LR2+BvlGDRxMEuSdki1emChK zLPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=i8JutcblGoAISDN3hurAlHLL13/lujc4PGXCcoNOdiE=; b=C9qxOudJXZiijrwL2CMOCEgnLJnTHw1Pj6Qr6nxBkXIQS+Onfux+B+LVSIdqGqB0ma IsxEbFV1VTQpa5n9oDYSQTMPfut6ah/yf3dWumfGTV//YUbShln22nFwmGDyW6sFdtk1 CedBH0qe6/elPNhEAmeNwounsPZQhIf5zxdb2QF58BXcjOI+hdxHi/5NdgD460k35lrU R6DgKGCEVBFCWuJPN3QwcKy4vkl9nl1idXzKXfM7utxrd4ZZwwvAkPUGFBv535jkV/Gw mZOp8iPWVjuBjxshcEx/gNLa1dpJmdHZ8BzZRuyVuxFpdItqfB85Jg9xnIz8xGVWw+wI mFWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=ZskJd2rQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a3si2878455edx.205.2020.05.21.05.28.26; Thu, 21 May 2020 05:28:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=ZskJd2rQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729285AbgEUMYr (ORCPT + 99 others); Thu, 21 May 2020 08:24:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727983AbgEUMYq (ORCPT ); Thu, 21 May 2020 08:24:46 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66A82C061A0E for ; Thu, 21 May 2020 05:24:45 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id j21so8604455ejy.1 for ; Thu, 21 May 2020 05:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=i8JutcblGoAISDN3hurAlHLL13/lujc4PGXCcoNOdiE=; b=ZskJd2rQupY8tV+of+gT2pNGrghG1kvcp0tUt8lYVHWX2N2357xtDLydnxma2icUrj b0RUe9qLlaHWLEn5ePS8DecHifXObN+IFUNHUwWuvKcDjwbkP7AMXFLIg+NakaL4dG4H XE7j3wic9ZZzBWOrSIpnnr08PFqEOA4rd/aeM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=i8JutcblGoAISDN3hurAlHLL13/lujc4PGXCcoNOdiE=; b=KAIHpHs+AsvoKTFnh/yzomtRCtR0fTPI+bPFAz756GR6Li+dP3fRqoYgbyCpdIwfb8 bwvK/eJSdrpfQDmS/Xt0a8jsV5nptXzSay+zQtNKxVrUSmoIq1/2ZYnKRc8aS5lO2fcv hphcNyazx7ANPKf6XFi5YGs/DIOEwMQZKtKaMdm5JJfu76DKd6zEl0SdATTOhkc5T5YX QoJqT0DI/9BJvOJrRsmDsFNvDO8//fakVaR5n12d/d+6k9CR01qDp/GN3nbJAP2gC2u7 eXAHK1hXeuROuUtxUVt2Rg5z5FzSnA7bYefb4Pj2D8jhYkKse+frAjYWAEIzCvlxWrHd Ugcw== X-Gm-Message-State: AOAM530uRPx7eFXIjAeJEcLFlUwqPulUPP1kAIy94Em2/Gs1enJp8JWp gLC1BpN4bdxXPA0Cd9c1bFRwxA9KYcfgPW0Y X-Received: by 2002:a17:906:3b8d:: with SMTP id u13mr3240093ejf.256.1590063884112; Thu, 21 May 2020 05:24:44 -0700 (PDT) Received: from localhost ([2620:10d:c093:400::5:4262]) by smtp.gmail.com with ESMTPSA id qn17sm4672101ejb.125.2020.05.21.05.24.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2020 05:24:43 -0700 (PDT) Date: Thu, 21 May 2020 13:24:38 +0100 From: Chris Down To: Michal Hocko Cc: Andrew Morton , Johannes Weiner , Tejun Heo , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH] mm, memcg: reclaim more aggressively before high allocator throttling Message-ID: <20200521122438.GC990580@chrisdown.name> References: <20200520143712.GA749486@chrisdown.name> <20200520160756.GE6462@dhcp22.suse.cz> <20200520202650.GB558281@chrisdown.name> <20200521071929.GH6462@dhcp22.suse.cz> <20200521112711.GA990580@chrisdown.name> <20200521120455.GM6462@dhcp22.suse.cz> <20200521122327.GB990580@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200521122327.GB990580@chrisdown.name> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chris Down writes: >A cgroup is a unit and breaking it down into "reclaim fairness" for >individual tasks like this seems suspect to me. For example, if one >task in a cgroup is leaking unreclaimable memory like crazy, everyone >in that cgroup is going to be penalised by allocator throttling as a >result, even if they aren't "responsible" for that reclaim. s/for that reclaim/for that overage/