Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1390980ybk; Thu, 21 May 2020 05:55:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKlIrTZHWBlSeU4wfjH/FLsy4vK4GEDhlQCOg3oVRliiC/+8J7fFLqBIhSfmidFvyrAIjB X-Received: by 2002:a17:906:6411:: with SMTP id d17mr3264402ejm.109.1590065711455; Thu, 21 May 2020 05:55:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590065711; cv=none; d=google.com; s=arc-20160816; b=iTBinF/Py+IKWIOVF3V8qR9BHK02bfFmMLAEbwCk/DIwxWqoZpMBE1P7bloSkQJXln e9LhG3PTYz9XjcjNsGK7GVSmCvpBDz8bb0tWMIQ7kXNuXTrwoc6tEOrlOJaHWnwp0PJT 8FaiG3ad5ZEYsr0BU9Dqz1Z2GOchk/KfeNEhYXZk+zz8253F3WPWYEv9mwFj02w1kCKl JQahHvgtduQao6UVCmpCGw9LPRnuxZTLxbM8IImjGp4AiIDRq9KNxi2vVE4mOHAykMlD FXcH5dgo4UonzyOUnGl3LhzpT7YEmD99trb5pYvuHALIEzIzPfvzZWxnuUtEvcaFfs3e LRsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=HhdS0k1uvFyYcnFyKdAE7u2FGKBzACV32jA6ddp5U90=; b=e1ELzKSTbps3M1j7gyncDGK/oHxdZdkiG2eXDpu19xku0y+uldaQEpDZY/HrQodbVv z2DAevPHiGVqe3p2/DxAohSVBcWwmtthpwP9dpScF+ZOwBnySZS0bVqihcH2QQ10/V2f 0XSPWOx3Q6JGqCK4C0hsAIGMa726T9+PfkhpIXxwJMBPdFZ1xIW0+rAb+85frdJjVDxu BENn3PNs3HhrCg5KGcd+QBJcItrevHMxdSt38ZksoG0T0xP25xyMDxn6+vOB7ib9C896 PDXth453n1CGWKd3ss/DVVeN2OJ2PfjLe5HWiFjBZlwoxHdKKMfT3ADkAmcbH+JIujsp /sXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=B6AX0Bme; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ob21si3408257ejb.522.2020.05.21.05.54.47; Thu, 21 May 2020 05:55:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=B6AX0Bme; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729400AbgEUMwx (ORCPT + 99 others); Thu, 21 May 2020 08:52:53 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:43508 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729296AbgEUMww (ORCPT ); Thu, 21 May 2020 08:52:52 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 04LCqQBM073519; Thu, 21 May 2020 07:52:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1590065547; bh=HhdS0k1uvFyYcnFyKdAE7u2FGKBzACV32jA6ddp5U90=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=B6AX0BmewPmUOKJI5DJ3cIZn+mQtSxDXO9Avzp912H0DIeRRFYLdBCq5F1P0K/PX7 ZBFr4KNidcljuogeJKGXNVIzLhPqoT8rUaNRB9jQktX4F+5LUYW8hpz+7HKo+ea875 9xBCwVXNAZY05h0iL5muyCMfD/8jR9tAittuvtXQ= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 04LCqQkD089935 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 21 May 2020 07:52:26 -0500 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 21 May 2020 07:52:26 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 21 May 2020 07:52:26 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 04LCqPlK071033; Thu, 21 May 2020 07:52:26 -0500 Date: Thu, 21 May 2020 18:22:25 +0530 From: Pratyush Yadav To: CC: Alexandre Belloni , Boris Brezillon , Mark Brown , , , , , , Ludovic Desroches , Matthias Brugger , Miquel Raynal , Nicolas Ferre , Sekhar Nori , Richard Weinberger , Tudor Ambarus , Vignesh Raghavendra Subject: Re: [PATCH v5 05/19] mtd: spi-nor: add support for DTR protocol Message-ID: <20200521125225.odxcdjkoy5lckrbx@ti.com> References: <20200519142642.24131-1-p.yadav@ti.com> <20200519142642.24131-6-p.yadav@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 21/05/20 05:24PM, masonccyang@mxic.com.tw wrote: > > Hi Pratyush, > > > > @@ -311,6 +313,7 @@ struct flash_info { > > * BP3 is bit 6 of status register. > > * Must be used with SPI_NOR_4BIT_BP. > > */ > > +#define SPI_NOR_OCTAL_DTR_READ BIT(19) /* Flash supports octal DTR > Read. */ > > #define SPI_NOR_OCTAL_DTR_RDWR BIT(19) /* Support Octal DTR Read & Write > */ This flag only enables SNOR_HWCAPS_READ_8_8_8_DTR. It does not affect SNOR_HWCAPS_PP_8_8_8_DTR. So it shouldn't be called RDWR. > more precisely and clearly ? > > thanks, > Mason > -- Regards, Pratyush Yadav Texas Instruments India