Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1414934ybk; Thu, 21 May 2020 06:25:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyt044jihNNb3uKj3fOv219MUEeRuZ2xtpkLlturGbsRFwopzXorHcHW0tii30or03MsCYc X-Received: by 2002:a17:906:aad8:: with SMTP id kt24mr3754132ejb.54.1590067539544; Thu, 21 May 2020 06:25:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590067539; cv=none; d=google.com; s=arc-20160816; b=qksS6CIPmAOM1N7gvwYu1toKV3/qGKpTIx5m02b4VdchZgczs/bgNxGqP4W3bQ3XLR mAxO4THiKEvkwXSDlZ5IuPuDeNGk/KL8odT77do5wv8Tt+YVgWpMKz916YHcslvTRBFB LsH7yBYUyF3PKmfjUNfiK+a/vi85CHJfsyfiWE6pbzX7PpcE9MDQzmzZZ4NHTQ0mFe/w I9q+GgM4cVnbJuRPqG6iUQFHIHCme8be/wWu/SEf6z4T+t7gZMOwUDkIdAaqCETpP3Kq ycJArOE7p0PchRWIciFxKDDg3ifE+p1xJKvjxxVGe10RnXnKJ6ifBhxP+cRDcmGk4W8K PWDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ZgiiCf7yV4gJL0wD1WfzajtZUs2YRbHU0t+q3osVJy8=; b=iv8sGpyDUL4SqA0YgCBc7Jle0QK1KeVVDvuCBXICakLA891yfbvbdmGcxaTTwowAQX fSIG1MldNEiHVABAHzMHhrdaxGRvzEctRmhUK7g1nRkbch9+toMhdutW4JoHPzxXN9lh KRGCa1N0N2m2GM+lgl7IftFdHow7X7SiswbWQQAZB+Q+k22m7PFyRk8CfUtgGSqEO8ee D8zaKoc0M6xwlD22pkkI6lBIzEKmkQ1HRIWwWEDfp+EkTWNcqhPG9V01QTXFQa6HVm45 qITX0jTM8JEIeJtVzIQUWBL9Ksa5WsB+ZxXUFIWDv9ogh2S28mooTa482QNE8s/Ny6YL IVvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vaoWV6h9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dk15si2633190ejb.697.2020.05.21.06.25.15; Thu, 21 May 2020 06:25:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vaoWV6h9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729363AbgEUNXZ (ORCPT + 99 others); Thu, 21 May 2020 09:23:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728208AbgEUNXZ (ORCPT ); Thu, 21 May 2020 09:23:25 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A36AC061A0E for ; Thu, 21 May 2020 06:23:25 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id t7so2825777plr.0 for ; Thu, 21 May 2020 06:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZgiiCf7yV4gJL0wD1WfzajtZUs2YRbHU0t+q3osVJy8=; b=vaoWV6h9teezEjE8jpwOZzf737B2YusTXEr+g5naQ5F87EBzTy7uBhoHJKRwu6Nq4x 5ux/fJ0DKBM0h84GWOxHMk9pfzkcqmI1WSNvdNwKYsL1K9RGyLs9jRR0r4UjzudwQOA6 xH+MblwTsZZ5PbXmI2gOU4ijseeRPku0L01zskhMufuc/eJVAXnlhS9zjlN1fc50HHJq CRT3EjpO8oRlzgCdj3hA2Nuk0Yd43DI1ARm5EaJLGkv4GDQ7jiGByJEE6NG9VH0NRmVr QdHn5sFAv1iJZJc3cTEYmxLLT/rGfWXsO6pICQ59KxbEQJ3DlSwf6/c3Ikye1Gdu3th8 xVvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZgiiCf7yV4gJL0wD1WfzajtZUs2YRbHU0t+q3osVJy8=; b=oR3V/HSD4NjNz1k47ZiqEIjDbwxsmOibr/PViSuM6Zt/i1NaS6E+K2PA6/Ry6vl979 QkUNhqluROp4V3FMtJk8EowFWfz2sMy8amT+Oue8jHbIiOgBWR9KyKLGaL67QrpUEjJe Wk/96Td606I9yDHgZY3VsESxj4P+o1bxV8lkmW+YAx8JbY4CaDPfA6Un0u+hfbMJLAx1 cxXr3Z/34A6qa/PV3Q3BPnM8UCSu6LBsGGIKDDLGxq9HM6SNdKog9gEInWxrnonm6lnF cxAoJ/7C0WJYyUm6L+0kPDwvQCduoMMIhRZHMSvfcN2qtOCdCS8dq5rjLRuWnotNjFzi 65EQ== X-Gm-Message-State: AOAM53246HN+mgTfLhD8jzJ7xzZYmX9TyrII3OwNcGnAdrGF0u8fNGi4 4S7R+BEPaOK66GfPktfQ1Tb/ X-Received: by 2002:a17:90a:e30e:: with SMTP id x14mr11666354pjy.141.1590067404391; Thu, 21 May 2020 06:23:24 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2409:4072:69f:45f2:3d8d:3719:f568:7ee9]) by smtp.gmail.com with ESMTPSA id q17sm3973037pfq.117.2020.05.21.06.23.20 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 May 2020 06:23:22 -0700 (PDT) Date: Thu, 21 May 2020 18:53:18 +0530 From: Manivannan Sadhasivam To: Bhaumik Bhatt Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/7] Introduce features and debugfs/sysfs entries for MHI Message-ID: <20200521132318.GA3797@Mani-XPS-13-9360> References: <1589832241-13867-1-git-send-email-bbhatt@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1589832241-13867-1-git-send-email-bbhatt@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, May 18, 2020 at 01:03:54PM -0700, Bhaumik Bhatt wrote: > Introduce independent bus and device voting mechanism for clients and save > hardware information from BHI. > Allow reading and modifying some MHI variables for debug, test, and > informational purposes using debugfs. > Read values for device specific hardware information to be used by OEMs in > factory testing such as serial number and PK hash using sysfs. > I think this series is not yet ready. So will not merge any patches in this series for 5.8. Or let me know if there are any independent patches which should get merged. I'm planning to send the final 5.8 series to Greg by Friday. Thanks, Mani > This set of patches was tested on arm64 and x86. > > v3: > -Add patch to check for pending packets in suspend as a dependency for the > independent voting mechanism introduction > -Include register dump entry for debugfs to dump MHI, BHI, and BHIe registers > -Update commit message for the debugfs patch > -Updated Documentation/ABI with the required info for sysfs > -Updated debugfs patch to include a new KConfig entry and dependencies > -Updated reviewed-by for some patches > > v2: > -Added a new debugfs.c file for specific debugfs entries and code > -Updated commit text and addressed some comments for voting change > -Made sure sysfs is only used for serial number and OEM PK hash usage > > Bhaumik Bhatt (7): > bus: mhi: core: Abort suspends due to outgoing pending packets > bus: mhi: core: Introduce independent voting mechanism > bus: mhi: core: Use generic name field for an MHI device > bus: mhi: core: Introduce helper function to check device state > bus: mhi: core: Introduce debugfs entries and counters for MHI > bus: mhi: core: Read and save device hardware information from BHI > bus: mhi: core: Introduce sysfs entries for MHI > > Documentation/ABI/stable/sysfs-bus-mhi | 25 ++ > MAINTAINERS | 1 + > drivers/bus/mhi/Kconfig | 8 + > drivers/bus/mhi/core/Makefile | 5 +- > drivers/bus/mhi/core/boot.c | 17 +- > drivers/bus/mhi/core/debugfs.c | 501 +++++++++++++++++++++++++++++++++ > drivers/bus/mhi/core/init.c | 80 +++++- > drivers/bus/mhi/core/internal.h | 29 ++ > drivers/bus/mhi/core/main.c | 6 +- > drivers/bus/mhi/core/pm.c | 79 ++++-- > include/linux/mhi.h | 39 ++- > 11 files changed, 745 insertions(+), 45 deletions(-) > create mode 100644 Documentation/ABI/stable/sysfs-bus-mhi > create mode 100644 drivers/bus/mhi/core/debugfs.c > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project