Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752363AbWCPK5E (ORCPT ); Thu, 16 Mar 2006 05:57:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752365AbWCPK5E (ORCPT ); Thu, 16 Mar 2006 05:57:04 -0500 Received: from mx1.suse.de ([195.135.220.2]:29117 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1752363AbWCPK5C (ORCPT ); Thu, 16 Mar 2006 05:57:02 -0500 Date: Thu, 16 Mar 2006 11:56:57 +0100 Message-ID: From: Takashi Iwai To: Eugene Teo Cc: linux-kernel@vger.kernel.org, Frank van de Pol , Jaroslav Kysela , Takashi Iwai Subject: Re: Fix seq_clientmgr dereferences before NULL check In-Reply-To: <20060316014606.GA20609@eugeneteo.net> References: <20060316014606.GA20609@eugeneteo.net> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta24) (dandelion) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1698 Lines: 49 At Thu, 16 Mar 2006 09:46:06 +0800, Eugene Teo wrote: > > Fix cptr->pool dereferences before NULL check. cptr->pool must be non-NULL there, so just the if (cptr->pool) is superfluous. Takashi > Coverity bug #860 > > Signed-off-by: Eugene Teo > > --- linux-2.6/sound/core/seq/seq_clientmgr.c~ 2006-03-15 10:05:45.000000000 +0800 > +++ linux-2.6/sound/core/seq/seq_clientmgr.c 2006-03-16 09:41:05.000000000 +0800 > @@ -1862,12 +1862,13 @@ > cptr = snd_seq_client_use_ptr(info.client); > if (cptr == NULL) > return -ENOENT; > + if (cptr->pool == NULL) > + return -ENOENT; > memset(&info, 0, sizeof(info)); > info.output_pool = cptr->pool->size; > info.output_room = cptr->pool->room; > info.output_free = info.output_pool; > - if (cptr->pool) > - info.output_free = snd_seq_unused_cells(cptr->pool); > + info.output_free = snd_seq_unused_cells(cptr->pool); > if (cptr->type == USER_CLIENT) { > info.input_pool = cptr->data.user.fifo_pool_size; > info.input_free = info.input_pool; > > -- > 1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265 9BB8 5883 6DAA A6D1 2F80 > main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); } > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/