Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752291AbWCPLUv (ORCPT ); Thu, 16 Mar 2006 06:20:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752285AbWCPLUv (ORCPT ); Thu, 16 Mar 2006 06:20:51 -0500 Received: from ftp.linux-mips.org ([194.74.144.162]:53223 "EHLO ftp.linux-mips.org") by vger.kernel.org with ESMTP id S1751087AbWCPLUu (ORCPT ); Thu, 16 Mar 2006 06:20:50 -0500 Date: Thu, 16 Mar 2006 11:20:45 +0000 From: Ralf Baechle To: Eugene Teo Cc: linux-kernel@vger.kernel.org, Thomas Osterried DL9SAU , Hans Alblas PE1AYX Subject: Re: [PATCH] Hamradio: Fix a NULL pointer dereference in net/hamradio/mkiss.c Message-ID: <20060316112045.GA4067@linux-mips.org> References: <20060316064211.GA22681@eugeneteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060316064211.GA22681@eugeneteo.net> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 659 Lines: 18 On Thu, Mar 16, 2006 at 02:42:11PM +0800, Eugene Teo wrote: > Pointer ax is dereferenced before NULL check. > > Coverity bug #817 Coverity non-bug #817. The line discipline's ioctl method can only be called as long as sp_get(tty) is valid. Same for mkiss. Unless I'm wrong on the "locking rules" of the tty code that is and maybe that unobviousness is the real reason why the patch should be applied. Ralf - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/