Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Subject: Re: [PATCH v2] perf: arm_dsu: Support DSU ACPI devices.
From:   Tuan Phan <tuanphan@amperemail.onmicrosoft.com>
In-Reply-To: <20200521135557.GB12282@bogus>
Date:   Thu, 21 May 2020 08:50:28 -0700
Cc:     Tuan Phan <tuanphan@os.amperecomputing.com>,
        Mark Rutland <mark.rutland@arm.com>,
        patches@amperecomputing.com, Will Deacon <will@kernel.org>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <2684F75B-98BC-4C24-BF29-C5214F9CD3BB@amperemail.onmicrosoft.com>
References: <1589229160-18558-1-git-send-email-tuanphan@os.amperecomputing.com>
 <20200521135557.GB12282@bogus>
To:     Sudeep Holla <sudeep.holla@arm.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.0.173] (73.151.56.145) by CY4PR01CA0019.prod.exchangelabs.com (2603:10b6:903:1f::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23 via Frontend Transport; Thu, 21 May 2020 15:50:30 +0000
X-Mailer: Apple Mail (2.3608.80.23.2.2)
X-Originating-IP: [73.151.56.145]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 17767772-c034-423d-0bd0-08d7fd9eb0fa
X-MS-TrafficTypeDiagnostic: BYAPR01MB4680:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR01MB4680F45AA3A07E21594893C6E0B70@BYAPR01MB4680.prod.exchangelabs.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4303;
X-Forefront-PRVS: 041032FF37
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: GKKrP5crpGSRTJ5kfkmJhxh7yy1WVgk6f0fZnrcbdTwrumtmgfjXrqhWat6IYnClkzN+EqalaDMW2kqZsMiPu7fEreOZF2lEv8WiEi3thrzH8t476H948NXuc6fzJ7MBdlklSJntXqzV9K7dUnjEebJYUSaeZG2K7x/j8Z6KuXLwonuC6sdUeMz+R++UofxQK3JRaVfWnVrE0PeGk2LpOt4Oelp2Z4zRgerTbhBMiBEwicBIRxelEc/mYEvdgWs1/VWKOQrVsoQNrGi8jVUtjM7YdExzcSmzycXvcmxtW47wxJKGxTYhmFD3wx+KGa58uMAgzNc+jR+3hRWtLiLq7FBkZqEdRCFRp7LFlmSU5Cfqi+C0/5+HxNi/rLz2qWLKhqkF/kpAl0OQKlL5D912xbEQ8EjYoaZH0KqbcdDNqvU0CcMaUoZELmmDr7NTE770cxow+kT3fPJUiddY1JdDCjuXXh/akUATwUuQV66Sm8/pweQc0XrXn7L3a+CwRMSB8FGKlbnpfRxfeDsZcMdNQw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR01MB4598.prod.exchangelabs.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(376002)(396003)(39840400004)(136003)(366004)(478600001)(54906003)(16526019)(966005)(8936002)(5660300002)(4326008)(8676002)(6916009)(33656002)(2906002)(6486002)(52116002)(83170400001)(956004)(2616005)(16576012)(53546011)(42882007)(186003)(316002)(66556008)(66476007)(26005)(66946007);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: CstIhkSVTVCRMTZ/cukH1Uob2N7fjTHgv0zfwjO4KlCC7FvY/YSQY6RFNwDWJ+MPUJ5D7OGCJc30VsIpjXFeNRxg2bL1vJ8Psa302Qqk2/KmPGTrTs5SZQEWw1te+SXDOazh/QphsQ2gduxpC9NvTKAKpkQIBJLK4kaB4ai61QcHsL9+TLZlqCzHZQ53//0L0KgvKS9hSgGG5lECyXESDN7bP4iOtCDUA4J/IhKM1qf1jEigzD6q0v9lNUFA8CvBDJ8akqMxurtMMdCk53/UwwPhsSm/bSdBzLJlnoqrb1FmkQHaa/gE3kMzc/HMg5uXYUH0GZ8LqIlnlzJJEwtgVoOFMosk8bZ9KRVJTATsEzW3pa9+xuZRcyAttTjqi9hPikR4wnefrZN6vHsL1s3woX6cuRVDUf/gecAl+7wo395+7/B1HYpQmKDGp0UqhlDAMIA2AIMmvR9uMHEcKZ+qrWKkmiBEb3t3zCLbwlPOE64=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17767772-c034-423d-0bd0-08d7fd9eb0fa
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2020 15:50:31.4390
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wl0UIWOL/EkVDPDfwe2QB4rR6C1CGLfLfnXn9vb0xsVbNhYmO7AC68RdMAjvsCNpxo5U2faBDPmtWvHJsjgc/uPx0UjoIbAPfR3kMdEXdYzUzes/Yv7hObI+q2d3bV7L
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR01MB4680
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On May 21, 2020, at 6:55 AM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>=20
> On Mon, May 11, 2020 at 01:32:40PM -0700, Tuan Phan wrote:
>> Add ACPI node probing device support. Each DSU ACPI node
>> defines a "cpus" package with a per cpu MPIDR element.
>>=20
>> Signed-off-by: Tuan Phan <tuanphan@os.amperecomputing.com>
>> ---
>> Changes in v2:
>> - Removed IRQF_SHARED.
>> - Fixed ACPI runtime detection.
>>=20
>> The ACPI binding spec for DSU ACPI node is under beta and located
>> in ARM server group under project "ACPI on ARM".
>>=20
>> drivers/perf/arm_dsu_pmu.c | 71 ++++++++++++++++++++++++++++++++++++++++=
------
>> 1 file changed, 63 insertions(+), 8 deletions(-)
>>=20
>> diff --git a/drivers/perf/arm_dsu_pmu.c b/drivers/perf/arm_dsu_pmu.c
>> index 70968c8..784d177 100644
>> --- a/drivers/perf/arm_dsu_pmu.c
>> +++ b/drivers/perf/arm_dsu_pmu.c
>> @@ -11,6 +11,7 @@
>> #define DRVNAME		PMUNAME "_pmu"
>> #define pr_fmt(fmt)	DRVNAME ": " fmt
>>=20
>> +#include <linux/acpi.h>
>> #include <linux/bitmap.h>
>> #include <linux/bitops.h>
>> #include <linux/bug.h>
>> @@ -603,18 +604,21 @@ static struct dsu_pmu *dsu_pmu_alloc(struct platfo=
rm_device *pdev)
>> }
>>=20
>> /**
>> - * dsu_pmu_dt_get_cpus: Get the list of CPUs in the cluster.
>> + * dsu_pmu_dt_get_cpus: Get the list of CPUs in the cluster
>> + * from device tree.
>>  */
>> -static int dsu_pmu_dt_get_cpus(struct device_node *dev, cpumask_t *mask=
)
>> +static int dsu_pmu_dt_get_cpus(struct platform_device *pdev)
>> {
>> 	int i =3D 0, n, cpu;
>> 	struct device_node *cpu_node;
>> +	struct dsu_pmu *dsu_pmu =3D
>> +		(struct dsu_pmu *) platform_get_drvdata(pdev);
>>=20
>> -	n =3D of_count_phandle_with_args(dev, "cpus", NULL);
>> +	n =3D of_count_phandle_with_args(pdev->dev.of_node, "cpus", NULL);
>> 	if (n <=3D 0)
>> 		return -ENODEV;
>> 	for (; i < n; i++) {
>> -		cpu_node =3D of_parse_phandle(dev, "cpus", i);
>> +		cpu_node =3D of_parse_phandle(pdev->dev.of_node, "cpus", i);
>> 		if (!cpu_node)
>> 			break;
>> 		cpu =3D of_cpu_node_to_id(cpu_node);
>> @@ -626,11 +630,54 @@ static int dsu_pmu_dt_get_cpus(struct device_node =
*dev, cpumask_t *mask)
>> 		 */
>> 		if (cpu < 0)
>> 			continue;
>> -		cpumask_set_cpu(cpu, mask);
>> +		cpumask_set_cpu(cpu, &dsu_pmu->associated_cpus);
>> 	}
>> 	return 0;
>> }
>>=20
>> +/**
>> + * dsu_pmu_acpi_get_cpus: Get the list of CPUs in the cluster
>> + * from ACPI.
>> + */
>> +static int dsu_pmu_acpi_get_cpus(struct platform_device *pdev)
>> +{
>> +	int i, cpu, ret;
>> +	const union acpi_object *obj;
>> +	struct acpi_device *adev =3D ACPI_COMPANION(&pdev->dev);
>> +	struct dsu_pmu *dsu_pmu =3D
>> +		(struct dsu_pmu *) platform_get_drvdata(pdev);
>> +
>> +	ret =3D acpi_dev_get_property(adev, "cpus", ACPI_TYPE_PACKAGE, &obj);
>=20
> I don't see any property "cpus" in the document:
> DEN 0093 A (Generic ACPI for Arm Components 1.0) [1]
>=20
> Is there any newer updates that I need to look at ?
>=20
There is a newer DEN 0093 A version but it has not been public yet. Let aba=
ndon this
patch and I will post new one when the document has been finalized and avai=
lable to public.

Thanks,
=20
> --=20
> Regards,
> Sudeep
>=20
> [1] https://static.docs.arm.com/den0093/a/DEN0093_ACPI_Arm_Components_1.0=
.pdf