Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1656411ybk; Thu, 21 May 2020 11:59:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqeZ5jJOUNYaw2JQamAlxi1lUY7YwOcb1WpFbZk/d6UgjFdDKvfcTgC99Iphh0X53ym34O X-Received: by 2002:a05:6402:31b1:: with SMTP id dj17mr135007edb.142.1590087592776; Thu, 21 May 2020 11:59:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590087592; cv=none; d=google.com; s=arc-20160816; b=UQzw2kEtUkLNSYwUXutXTqHAiN7SgA8gcXU8mbejQ6bj9/cuIAjrMJBykb/aJ0mDyM UgBjqCjjXUTG97KrSqXiS8iLe17Iht27oLc1MuKceevhN62PajQ8qkqLOmgg0s2wORbG Vq7DImEsIEGWSqH5kkDF9huaNU6GoMK2TFU6nej0w3fNFRt5yD+9zBIQOJsRGrYIK5T1 Lxmm224ZFfomEmqvMVY+HyZs7EbPt/whJ0edp+J0H0NOd+/unE/MqSTj2KiAaaZ8wj0J Y2im6kJ9CrEFC+kzaDRx/nHv7KHAlRAglASpcjTBa35toRk4cf0lnrP/O/mR95x5VnSc mGgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:user-agent:message-id:subject:from :cc:to:references:in-reply-to:content-transfer-encoding:mime-version; bh=QoTvy/pIrY+Mm+48B/1+x0cfNAihvtslSSbWT+xDD5U=; b=KdQMdIvJunOAUx5MHbfZnToHv7FBY77prnzaIxfNbo2410/FZocyy7KF9zUwOGnWCC PBaNd01zx/MF6QGcNA34QCvHZ0JmrE5en+eRMjaFunmksEvWRKJyG3MEE6yC/O7JOL3l G2K+fmyGcKN3VwdS8ZqCUi87TzV5nh5McGC9+QJIiZtI1r1EpbBPj3Nuci66UdVNa5Fk bYZtbDAoYd8YTPN/3B92JFcc32BqNs+p8Sx49Wxn0t1zMww3sB4RR+BqS7GutdtsSmQc Dc3WJCjYJbXzuJ6EYiKiSdV5XN/h8c4+pMftaQSsweuBOFZBcJ37BiJXr7p+5Zi6wUx7 ckCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id re25si3766936ejb.627.2020.05.21.11.59.29; Thu, 21 May 2020 11:59:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729829AbgEUS5v convert rfc822-to-8bit (ORCPT + 99 others); Thu, 21 May 2020 14:57:51 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:49462 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729092AbgEUS5v (ORCPT ); Thu, 21 May 2020 14:57:51 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 21252267-1500050 for multiple; Thu, 21 May 2020 19:57:36 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT In-Reply-To: <20200519002124.2025955-1-jhubbard@nvidia.com> References: <20200519002124.2025955-1-jhubbard@nvidia.com> To: Andrew Morton , John Hubbard Cc: Souptick Joarder , Matthew Wilcox , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Tvrtko Ursulin , Matthew Auld , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, John Hubbard From: Chris Wilson Subject: Re: [PATCH 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages() Message-ID: <159008745422.32320.5724805750977048669@build.alporthouse.com> User-Agent: alot/0.8.1 Date: Thu, 21 May 2020 19:57:34 +0100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting John Hubbard (2020-05-19 01:21:20) > This needs to go through Andrew's -mm tree, due to adding a new gup.c > routine. However, I would really love to have some testing from the > drm/i915 folks, because I haven't been able to run-time test that part > of it. CI hit <4> [185.667750] WARNING: CPU: 0 PID: 1387 at mm/gup.c:2699 internal_get_user_pages_fast+0x63a/0xac0 <4> [185.667752] Modules linked in: vgem snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic i915 mei_hdcp x86_pkg_temp_thermal coretemp snd_hda_intel snd_intel_dspcfg crct10dif_pclmul snd_hda_codec crc32_pclmul snd_hwdep snd_hda_core ghash_clmulni_intel cdc_ether usbnet mii snd_pcm e1000e mei_me ptp pps_core mei intel_lpss_pci prime_numbers <4> [185.667774] CPU: 0 PID: 1387 Comm: gem_userptr_bli Tainted: G U 5.7.0-rc5-CI-Patchwork_17704+ #1 <4> [185.667777] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP, BIOS ICLSFWR1.R00.3234.A01.1906141750 06/14/2019 <4> [185.667782] RIP: 0010:internal_get_user_pages_fast+0x63a/0xac0 <4> [185.667785] Code: 24 40 08 48 39 5c 24 38 49 89 df 0f 85 74 fc ff ff 48 83 44 24 50 08 48 39 5c 24 58 49 89 dc 0f 85 e0 fb ff ff e9 14 fe ff ff <0f> 0b b8 ea ff ff ff e9 36 fb ff ff 4c 89 e8 48 21 e8 48 39 e8 0f <4> [185.667789] RSP: 0018:ffffc90001133c38 EFLAGS: 00010206 <4> [185.667792] RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffff8884999ee800 <4> [185.667795] RDX: 00000000000c0001 RSI: 0000000000000100 RDI: 00007f419e774000 <4> [185.667798] RBP: ffff888453dbf040 R08: 0000000000000000 R09: 0000000000000001 <4> [185.667800] R10: 0000000000000000 R11: 0000000000000000 R12: ffff888453dbf380 <4> [185.667803] R13: ffff8884999ee800 R14: ffff888453dbf3e8 R15: 0000000000000040 <4> [185.667806] FS: 00007f419e875e40(0000) GS:ffff88849fe00000(0000) knlGS:0000000000000000 <4> [185.667808] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4> [185.667811] CR2: 00007f419e873000 CR3: 0000000458bd2004 CR4: 0000000000760ef0 <4> [185.667814] PKRU: 55555554 <4> [185.667816] Call Trace: <4> [185.667912] ? i915_gem_userptr_get_pages+0x1c6/0x290 [i915] <4> [185.667918] ? mark_held_locks+0x49/0x70 <4> [185.667998] ? i915_gem_userptr_get_pages+0x1c6/0x290 [i915] <4> [185.668073] ? i915_gem_userptr_get_pages+0x1c6/0x290 [i915] and then panicked, across a range of systems. -Chris