Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751458AbWCPPMZ (ORCPT ); Thu, 16 Mar 2006 10:12:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751318AbWCPPMZ (ORCPT ); Thu, 16 Mar 2006 10:12:25 -0500 Received: from mx.pathscale.com ([64.160.42.68]:5051 "EHLO mx.pathscale.com") by vger.kernel.org with ESMTP id S1751320AbWCPPMY (ORCPT ); Thu, 16 Mar 2006 10:12:24 -0500 Subject: Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver From: "Bryan O'Sullivan" To: Roland Dreier Cc: Andrew Morton , Hugh@veritas.com, torvalds@osdl.org, hch@infradead.org, linux-kernel@vger.kernel.org In-Reply-To: References: <71644dd19420ddb07a75.1141922823@localhost.localdomain> <1141948516.10693.55.camel@serpentine.pathscale.com> <1141949262.10693.69.camel@serpentine.pathscale.com> <20060309163740.0b589ea4.akpm@osdl.org> <1142470579.6994.78.camel@localhost.localdomain> <1142475069.6994.114.camel@localhost.localdomain> <1142477579.6994.124.camel@localhost.localdomain> <20060315192813.71a5d31a.akpm@osdl.org> <1142485103.25297.13.camel@camp4.serpentine.com> <20060315213813.747b5967.akpm@osdl.org> Content-Type: text/plain Date: Thu, 16 Mar 2006 07:12:23 -0800 Message-Id: <1142521943.25297.42.camel@camp4.serpentine.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 820 Lines: 23 On Wed, 2006-03-15 at 21:54 -0800, Roland Dreier wrote: > How about the case where one wants to map pages from > dma_alloc_coherent() into userspace? This is precisely our case, btw. The pages in question are allocated during fops->open (some during dev->probe). mmap and nopage never allocate anything. > It seems one should do > get_page() in .nopage, and then the driver can do dma_free_coherent() > when the vma is released. If that were the case, I'm unclear on how I would do this. Add a vmops->close method along with the existing vmops->nopage handler?