Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1719727ybk; Thu, 21 May 2020 13:36:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxDXh7I3Vd6+rao6Yatc2O1t1efIC/lxKH/48TuEWjMvTOzE7Aa6uKsb6vFNkv7T2906yKv X-Received: by 2002:a17:906:9493:: with SMTP id t19mr5017272ejx.461.1590093402565; Thu, 21 May 2020 13:36:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590093402; cv=none; d=google.com; s=arc-20160816; b=SSNXUzEdP/Lag/pRIeYsh7RVRf/OUavWcCK/BYQtB6usMSG/THxaPI2ocCjSfS7+sF EsR9/HOkYPOthH5CYT8Fj8EAX0WCKM3q9TgMzv0/EB1ZrJCCfpcCNm/2jB8+3KVdYMxz eeWPOWiQTURe0j/KAQs7NsRKbvDgjclyc989QlV7gwIvWuzhOr1PgAq9MoNe6Ck1M4LP QPdZhKZwqMjFdlxSXAF55Cy2jedeauEpj+g9kGRI4tm3U5sI+6m27D9wWH2i137iSuNw ZwTmUvZvTaaxajDKGy+seJSSamtshHFtKCSRSCrzct3BC6bHErOEVSGKgJZSzaia2BkX 0e3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=mbogiIJ51R5QdW+/MJYLWt5NYi1vk9juLL/j738tJCo=; b=ouBHFzmJX8TzpLECuU/t300szMU64+hl/zyqUG8Z02Gtk1AdSM8fkERD8koW8pDWRj /zn7JUG/6C1hQgcpGt/sUprsIRrNua3O6Prk/uXvYjHsRD9JismLGLget9cyG3i3G3DW s5kIn3sBtnPRwQdYgRikg3soaI2l67Uqu47tyQz2MTcVjSWLZjXKbprItPdHysAqFFPk zBqFtQFgNz5/jMLKiJJqy8Z2Eg7/+mWnrSfaIpzVW7Gw7+g1QQgq3n14fvFqaD/VAjF9 oX0QV3gr6vb6YN2MTj3GtA4aKfFs7MYXxiFWp2+nBdjyCm0L3zIu4Wmd8sufdawp6JIN f4Tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=JTOfIrn9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g8si3898950eje.444.2020.05.21.13.36.19; Thu, 21 May 2020 13:36:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=JTOfIrn9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729651AbgEUUe2 (ORCPT + 99 others); Thu, 21 May 2020 16:34:28 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:57396 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729506AbgEUUe1 (ORCPT ); Thu, 21 May 2020 16:34:27 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 04LKYNk9061073; Thu, 21 May 2020 15:34:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1590093263; bh=mbogiIJ51R5QdW+/MJYLWt5NYi1vk9juLL/j738tJCo=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=JTOfIrn9vJEzT/LRspFQIMrCSlPqJJnn4ru/b7uHRnVtzsSxSaxmLmhL9ttwV25Bi yMuW0kejsUuQhuzawDezhpBFGLEyiFwPShWFfJ0TPyVJ5/TMdrhiI5Ih60VymwLByk MEqU9suBWd/tk7nLCDvuC2PXV0i4vTIYv+c0orZw= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 04LKYNoE057209 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 21 May 2020 15:34:23 -0500 Received: from DLEE108.ent.ti.com (157.170.170.38) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 21 May 2020 15:34:22 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 21 May 2020 15:34:22 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 04LKYM42068417; Thu, 21 May 2020 15:34:22 -0500 Date: Thu, 21 May 2020 15:34:22 -0500 From: Bin Liu To: Paul Cercueil CC: , , Subject: Re: [PATCH] usb: musb: jz4740: Prevent lockup when CONFIG_SMP is set Message-ID: <20200521203422.GA25575@iaqt7> Mail-Followup-To: Bin Liu , Paul Cercueil , od@zcrc.me, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200520150111.76658-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200520150111.76658-1-paul@crapouillou.net> User-Agent: Mutt/1.9.4 (2018-02-28) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 20, 2020 at 05:01:11PM +0200, Paul Cercueil wrote: > The function dma_controller_irq() locks up the exact same spinlock we > locked before calling it, which obviously resulted in a deadlock when > CONFIG_SMP was enabled. This flew under the radar as none of the boards > supported by this driver needs SMP. > > Fixes: 57aadb46bd63 ("usb: musb: jz4740: Add support for DMA") > Signed-off-by: Paul Cercueil Queued for v5.8. Thanks. -Bin.