Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1722560ybk; Thu, 21 May 2020 13:41:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxEeFFVw/xvPCdj6tKPAVX7esJ/3eLzT9W7EgaCJngdUTBc9yF042nuYvYQShjbPs7W9N64 X-Received: by 2002:a17:906:a1da:: with SMTP id bx26mr5706526ejb.42.1590093675883; Thu, 21 May 2020 13:41:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590093675; cv=none; d=google.com; s=arc-20160816; b=nyzn/+NnA4xCovQPRdVcinu4+NJ/LtLlwElBLzOU88f2r8YZBFE4vTfnik+a9UfR0o kQSl32Y2iJJlEsNtxUDLD0tVGSuR0fzHhSP7SFmAwIC47BB3WdRKLt8W+cPj2mmjFPAp B8jpie2VdFKVtCuCSehygEOqqdp/f0U/ru2XI+yppsUQOV9647iKu8zPJAIAGcHQFZ7F OgAVs9xBCGoBwJ0qqr/3SbbB3QMlblqI0x965uHiB+3FJZnDikJuY6bC7MQGWNofPCWr fgC8EG0Q+TQ6cXLlxGtKAtDKHcJ1CPBG0T1bvIiNDVQf/WwGusOl6/KjT1ZNFGdWrhxF Kz1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:cc:to:subject:from:date :dkim-signature; bh=Tqs4AvNuoDMNDO2I27A5TOgvOdzT2DKGMDK0YpZqlAc=; b=toyk4d1pcSTY9wkEq3LFS6ImpAh9ZGTi79PuIKrvOYkHnG3JXTdRulIuZYlledXvk9 qBcEQgK0ZNZzIfv67B6PJEmEcCHk3j31Uoeocnhq86BKAWFO0pcAm+oGkbOZXrwUCoou QE0pIC6huelLJOOsA8J62GyXj6XtRDr3VWVQefn1PMV5IzGEDVLbFPaIhe9Ubv8WeR4q evmEfQVYiKfAdFQd2RsHXq8fGKOw9oREzHXDzgGJFlJJ8BOiV95ZbogPpRlj/T0pKnMG z58Hjr12YS6JuNjOT6ZoeZc1bTKHXCtgHbPGLeP7UH8XcXJhwuycxLDX6Gqn4KF6B2Vt Hytw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@crapouillou.net header.s=mail header.b=WyRrdUVX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id re19si3756794ejb.56.2020.05.21.13.40.53; Thu, 21 May 2020 13:41:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@crapouillou.net header.s=mail header.b=WyRrdUVX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729596AbgEUUji (ORCPT + 99 others); Thu, 21 May 2020 16:39:38 -0400 Received: from outils.crapouillou.net ([89.234.176.41]:55440 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728869AbgEUUjh (ORCPT ); Thu, 21 May 2020 16:39:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1590093575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tqs4AvNuoDMNDO2I27A5TOgvOdzT2DKGMDK0YpZqlAc=; b=WyRrdUVXj3rYXqc/O6lsvlXriCtU+H2xdG53omV1Mr5AgQiQpxq6KMlithFeoGGOm6Vc3I je0VDVoCMS/4gf370xlISMucr37kPmMPYqPU9drgcwUJeyyesEboP8AMaanf7Zle7VPJnv 44qnzVuLuPyKOYqiAUjcz7wVl3SvWu8= Date: Thu, 21 May 2020 22:39:25 +0200 From: Paul Cercueil Subject: Re: [PATCH] usb: musb: jz4740: Prevent lockup when CONFIG_SMP is set To: Bin Liu Cc: od@zcrc.me, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <20200521203422.GA25575@iaqt7> References: <20200520150111.76658-1-paul@crapouillou.net> <20200521203422.GA25575@iaqt7> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bin, The patch it fixes was introduced in 5.7-rc1, is it possible to queue=20 it for the next -rc? Otherwise I'll need to Cc it to linux-stable. -Paul Le jeu. 21 mai 2020 =E0 15:34, Bin Liu a =E9crit : > On Wed, May 20, 2020 at 05:01:11PM +0200, Paul Cercueil wrote: >> The function dma_controller_irq() locks up the exact same spinlock=20 >> we >> locked before calling it, which obviously resulted in a deadlock=20 >> when >> CONFIG_SMP was enabled. This flew under the radar as none of the=20 >> boards >> supported by this driver needs SMP. >>=20 >> Fixes: 57aadb46bd63 ("usb: musb: jz4740: Add support for DMA") >> Signed-off-by: Paul Cercueil >=20 > Queued for v5.8. Thanks. > -Bin.