Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1757035ybk; Thu, 21 May 2020 14:39:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpRaDqr5QuhjwY18was+EHMwdjK+2W2U8HpeUMfJU1xBlTZ/vvEv0MltFZbYFBWZ7mfV6Q X-Received: by 2002:a17:906:658a:: with SMTP id x10mr5301727ejn.479.1590097161079; Thu, 21 May 2020 14:39:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590097161; cv=none; d=google.com; s=arc-20160816; b=Codx5Eas3hn+DCcln+MuAn/GyASLzFJJFE4YRq+UxGtrA8R19U7LfizdLyP+a4uurM dTEWn1W4A1S+yNNQ1CurFMSqOHhdBYVPnpXTikMhcSxnnQPJDTs4gDwQor5D+ZDnoebC qtnhUqMm7Y0+uLB762s3uj1uhFg59rEJvXrEVS3FowjXscYqTlu0UtD6qUwUXX2HlnVA UpZIP1j/PYzgKgIqFGXgqqyJlUY12iydC7r9/Jz1PCLl+mgaY8PfFIV3O4yrb3jK7YOC hR+TK4nrBEX8BLADdAbLLzu0HASx7M7sE6PeL0qntMDPUpFskjTqTumaWhTbvWeK658C y4jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=ImubOodhVUuvlPv+r5HZnPO/8KSbbnKVFHwT0r5OyEU=; b=jDAx4qa5mgLqLka20OFg7VNGNTOgs93SYBRNqe475s556HuKvTE6ghcQRUoE6ziITS ffwVTEvuBxHxaXUJLF+mRfDiVGJNmeUAx54e2BDx8fKfWEHAfhqNLyVNFWhdcWJEZtXm QiXQVm0fPzoSw9goZqAHBcPM2wRR8b2WuaW1Qt1RIGFKFBb7LFEksA2ET5H12RmL0wd3 Dwry1ggyF7YK5pagrn0ZsjuxDfnV4MKwoYhWZayjymnXl066BunWXqiMiK7ElAj8HLR8 jDKYHeVaxphQIxXmfOTHm1rhZJOn6tr3rFGDALYWmpsgCqVVgyECUZeuT0K00e3/dIk4 Eg9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h23si4036781ejb.269.2020.05.21.14.38.58; Thu, 21 May 2020 14:39:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729492AbgEUVh1 (ORCPT + 99 others); Thu, 21 May 2020 17:37:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728971AbgEUVh1 (ORCPT ); Thu, 21 May 2020 17:37:27 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81B56C061A0E; Thu, 21 May 2020 14:37:27 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 133D4120ED482; Thu, 21 May 2020 14:37:27 -0700 (PDT) Date: Thu, 21 May 2020 14:37:26 -0700 (PDT) Message-Id: <20200521.143726.481524442371246082.davem@davemloft.net> To: kuba@kernel.org Cc: tanhuazhong@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, salil.mehta@huawei.com, yisen.zhuang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature From: David Miller In-Reply-To: <20200521121707.6499ca6b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> References: <1590061105-36478-1-git-send-email-tanhuazhong@huawei.com> <20200521121707.6499ca6b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 May 2020 14:37:27 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jakub Kicinski Date: Thu, 21 May 2020 12:17:07 -0700 > On Thu, 21 May 2020 19:38:23 +0800 Huazhong Tan wrote: >> This patchset adds two new VLAN feature. >> >> [patch 1] adds a new dynamic VLAN mode. >> [patch 2] adds support for 'QoS' field to PVID. >> >> Change log: >> V1->V2: modifies [patch 1]'s commit log, suggested by Jakub Kicinski. > > I don't like the idea that FW is choosing the driver behavior in a way > that's not observable via standard Linux APIs. This is the second time > a feature like that posted for a driver this week, and we should > discourage it. Agreed, this is an unacceptable approach to driver features.