Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200521222551.259804-1-irogers@google.com>
In-Reply-To: <20200521222551.259804-1-irogers@google.com>
From:   Ian Rogers <irogers@google.com>
Date:   Thu, 21 May 2020 16:13:48 -0700
Message-ID: <CAP-5=fXjXgWEgp9gqReByrDBTvjDbPEsubeAFxrpxj_+FsFn6w@mail.gmail.com>
Subject: Re: [PATCH] proc.5: add "wf" to VmFlags in /proc/[pid]/smaps
To:     Rik van Riel <riel@redhat.com>, mtk.manpages@gmail.com
Cc:     linux-man@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        linux-mm@kvack.org, linux-api@vger.kernel.org, nilal@redhat.com,
        Florian Weimer <fweimer@redhat.com>,
        =?UTF-8?Q?Colm_MacC=C3=A1rtaigh?= <colm@allcosts.net>,
        Mike Kravetz <mike.kravetz@oracle.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, May 21, 2020 at 3:25 PM Ian Rogers <irogers@google.com> wrote:
>
> This patch documents a flag added in the following kernel commit:
>
> commit d2cd9ede6e193dd7d88b6d27399e96229a551b19
> Author: Rik van Riel <riel@redhat.com>
> Date:   Wed Sep 6 16:25:15 2017 -0700
>
>     mm,fork: introduce MADV_WIPEONFORK
>
> This was already documented in man2/madvise.2 in the commit:
>
> commit c0c4f6c29c494c466f3a2a6273c5b55b76a72927
> Author: Rik van Riel <riel@redhat.com>
> Date:   Tue Sep 19 20:32:00 2017 +0200
>
>     madvise.2: Document MADV_WIPEONFORK and MADV_KEEPONFORK
>
> Signed-off-by: Ian Rogers <irogers@google.com>

Doing a quick audit of fs/proc/task_mmu.c having noticed this flag was
missing I note:
 - "mp" isn't documented, only possible with INTEL_MPX
 - "nl" is documented but not present in show_smap_vma_flags
 - "um" and "uw" aren't documented

Thanks,
Ian

> ---
>  man5/proc.5 | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/man5/proc.5 b/man5/proc.5
> index 46d603f28..3e5b91af0 100644
> --- a/man5/proc.5
> +++ b/man5/proc.5
> @@ -2020,6 +2020,7 @@ encoded using the following two-letter codes:
>      ht  - area uses huge tlb pages
>      nl  - non-linear mapping
>      ar  - architecture specific flag
> +    wf  - wipe on fork
>      dd  - do not include area into core dump
>      sd  - soft-dirty flag
>      mm  - mixed map area
> --
> 2.27.0.rc0.183.gde8f92d652-goog
>