Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1828795ybk; Thu, 21 May 2020 16:42:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPMC/9qBo6Cs9IXApAb5ialbIFxdFak4vr76k0Q+Zm+VBmLdHTuNwGuTjvujoYaNLWGcGo X-Received: by 2002:a17:906:b348:: with SMTP id cd8mr5705960ejb.139.1590104557204; Thu, 21 May 2020 16:42:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590104557; cv=none; d=google.com; s=arc-20160816; b=PtcvKPqs4ODPNxI2FzRClMg4HqrV/aYLQC0iOSuC9831fp2uegj/Dix09LLXYa6/gc hFJSKjlRh98gDCncLZfy1GQOjmbvmcJbjQ7CyYoQQlkuShK1NeyfHXqtCfbpjSk8nHZY Qh9Uu8IrS0/Yy1s0y95rSqQ/HSGc6WsanCFdfs/X9IjiVBkq19RpMXZi5rxxOd3j8enx u9kUJKPi6NOmVdZvrPrV7cE76WPNSES75PBjghodHyKTr3ToR0w5iOD+ED883GZRflPq CNBmTpgPW6KkRYH9KDbBTaw2MOEK3UGR15CMJpkjYsQwFmqit6MPQLVUV4cakBxR5sXa LhwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:cc:ironport-sdr:ironport-sdr; bh=LUT4Vy6u0CcnnXLnaR9YAWB7zY/fN8M6XNbuQ3uyNMM=; b=iAcZWDzR1pF20khVba1ymdguRaYet98q9LNl95plJw6j5N+7ktt9LWbrMzg/7md15D DQKi2pnWkioCqxQXVzkks6ZnBrPjWzmtujqG+O9FbrLDBi4YDbAG04pJ0mEnOf24eGzw 2vtLUMRG1/oCg1ekV912QyEPW/Nb7C0t+3Vmp4vM9CTCi3gw840RZuWP4Wcss9TwUCd4 AZX9UkmeHk++T1vBmY3fC4r4BOTwcO0vuX1DJ0AlwXA17IKH+3kLmMc5Uiju/qK7dSNN otUNwD+8+Idq6wsJmALS+iZZUgl1sY+fkAEKLSFyaM/Wxh6fT/ot4ipg5BsDgS8g84lh BCtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sd5si4219978ejb.194.2020.05.21.16.42.14; Thu, 21 May 2020 16:42:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730063AbgEUXkx (ORCPT + 99 others); Thu, 21 May 2020 19:40:53 -0400 Received: from mga12.intel.com ([192.55.52.136]:44255 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729827AbgEUXkx (ORCPT ); Thu, 21 May 2020 19:40:53 -0400 IronPort-SDR: CMP/rHqsP4yxK01NwUrghWpJLhMDwgVzMBmJcCnCFvFUfypSU62o6uL6ccRX9F89hn+bP5UbL0 g9cKl4qoyoBg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2020 16:40:52 -0700 IronPort-SDR: oMV6pdOLmBBvp2tg/0s2cHXMXmtpef4jgFMpno2H4JRWJDg9h3nQBjoD400muqIm8TlxWhzOzA IvQNURBpQYgQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,419,1583222400"; d="scan'208";a="283229047" Received: from allen-box.sh.intel.com (HELO [10.239.159.139]) ([10.239.159.139]) by orsmga002.jf.intel.com with ESMTP; 21 May 2020 16:40:49 -0700 Cc: baolu.lu@linux.intel.com, jacob.jun.pan@linux.intel.com, yi.l.liu@intel.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] iommu/vt-d: fix a GCC warning To: Qian Cai , jroedel@suse.de References: <20200521215030.16938-1-cai@lca.pw> From: Lu Baolu Message-ID: <27cf90e4-57bc-38da-fa30-69244f006f63@linux.intel.com> Date: Fri, 22 May 2020 07:37:13 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200521215030.16938-1-cai@lca.pw> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Qian, Thanks! On 5/22/20 5:50 AM, Qian Cai wrote: > The commit 6ee1b77ba3ac ("iommu/vt-d: Add svm/sva invalidate function") > introduced a GCC warning, > > drivers/iommu/intel-iommu.c:5330:1: warning: 'static' is not at beginning of > declaration [-Wold-style-declaration] > const static int > ^~~~~ > > Signed-off-by: Qian Cai Fixes: 6ee1b77ba3ac0 ("iommu/vt-d: Add svm/sva invalidate function") Acked-by: Lu Baolu Best regards, baolu > --- > drivers/iommu/intel-iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c > index f75d7d9c231f..ff5a30a94679 100644 > --- a/drivers/iommu/intel-iommu.c > +++ b/drivers/iommu/intel-iommu.c > @@ -5327,7 +5327,7 @@ static void intel_iommu_aux_detach_device(struct iommu_domain *domain, > * [IOMMU_CACHE_INV_TYPE_IOTLB][IOMMU_INV_GRANU_ADDR] > */ > > -const static int > +static const int > inv_type_granu_table[IOMMU_CACHE_INV_TYPE_NR][IOMMU_INV_GRANU_NR] = { > /* > * PASID based IOTLB invalidation: PASID selective (per PASID), >