Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1849915ybk; Thu, 21 May 2020 17:21:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZTSF4zM1Ey5oa1kHFrX035dBF+KQF3jEBoTl7wt6MHFs4vNoHXDuEWPHhla23szwMyFvr X-Received: by 2002:a17:906:8514:: with SMTP id i20mr5614030ejx.298.1590106864485; Thu, 21 May 2020 17:21:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590106864; cv=none; d=google.com; s=arc-20160816; b=uV920zUWqdRZpG6p4IiblafW+mIg3det95By75mp6i7TxdkaxE+xWG+mu09UQRU5jb QdYL+7YFopCFAVUkId8sk4xdW2JaLIqbET35mFuUsQT7uIsCdknfnsrkdYyBtcGc2OWp 7po1cByFSkowGCzeQo2aXV0x+Ihe80NOPK+vxzyqZ/lvhy+fpL9kicO30h5zS71NsU5p dHpn7K4W0HS64a9oFbWmS+8Sd/AtwYTd+avTD3bki9j73pIoYvXZjpBqgUWGNmPLrp5k 1PCE37Ysm1bkQC67aTMdn1vWfWfP1c/52JS9NPmWQTPz0ubAQ7xaZv93cZISRaootOxp AoUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=HEiBA7grp4ZDH+ruYJP2Jxbkz/i4ACRfIu371sre1nk=; b=t8NQS/wjYj3p+cJIq9ivfIR+dWRdWM2QuP6VXC3EPitGl8G4Mvdr6DwO4d3XkiUz67 e8kk0c4RBPulgQuQxumB3NKTXgf39pw4Y8gmXTn1bu8OL9dtc8ig4r44X7MbwVGF3EG2 tiCDz6fewb2kseawUlu0sTBpaGx29XARZIr0kKbJ4Fk6iGdv/sRn18BK1ckSpqFnQL5J lS+HBEWR0cA+DF3oQJI8Pcib68ppCo1bmIy5fnsfg1vXy8SCNEPnTUsvqgIYPSu1ON9X CdJ/uPSIZNHGN7roFv9q0KQ4MyiPzLmyZs7ygn4JfnjGpVS52gpo/7SuvSnq+UXAjOuZ H0hw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b13si4314595ejg.10.2020.05.21.17.20.40; Thu, 21 May 2020 17:21:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728312AbgEVASS (ORCPT + 99 others); Thu, 21 May 2020 20:18:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726903AbgEVASS (ORCPT ); Thu, 21 May 2020 20:18:18 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 243BBC061A0E; Thu, 21 May 2020 17:18:18 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B44B4120ED48B; Thu, 21 May 2020 17:18:16 -0700 (PDT) Date: Thu, 21 May 2020 17:18:15 -0700 (PDT) Message-Id: <20200521.171815.1268044117965833956.davem@davemloft.net> To: o.rempel@pengutronix.de Cc: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, kuba@kernel.org, corbet@lwn.net, mkubecek@suse.cz, david@protonic.nl, kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux@armlinux.org.uk, mkl@pengutronix.de, marex@denx.de, christian.herber@nxp.com Subject: Re: [PATCH net-next v3 0/2] provide KAPI for SQI From: David Miller In-Reply-To: <20200520062915.29493-1-o.rempel@pengutronix.de> References: <20200520062915.29493-1-o.rempel@pengutronix.de> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 May 2020 17:18:17 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oleksij Rempel Date: Wed, 20 May 2020 08:29:13 +0200 > This patches are extending ethtool netlink interface to export Signal > Quality Index (SQI). SQI provided by 100Base-T1 PHYs and can be used for > cable diagnostic. Compared to a typical cable tests, this value can be > only used after link is established. > > changes v3: > - rename __ethtool_get_sqi* to linkstate_get_sqi*. And move this > functions to the net/ethtool/linkstate.c > - protect linkstate_get_sqi* with locking > > changes v2: > - use u32 instead of u8 for SQI > - add SQI_MAX field and callbacks > - some style fixes in the rst. > - do not convert index to shifted index. Series applied, thank you.