Date: Thu, 16 Mar 2006 08:36:54 -0800
From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: hch@infradead.org, akpm@osdl.org, linux-kernel@vger.kernel.org,
       aia21@cantab.net, len.brown@intel.com
Subject: Re: [patch 1/1] consolidate TRUE and FALSE
Message-Id: <20060316083654.d802f3f3.rdunlap@xenotime.net>
In-Reply-To: <20060316163001.GA7222@infradead.org>
References: <200603161004.k2GA46Fc029649@shell0.pdx.osdl.net>
	<20060316160129.GB6407@infradead.org>
	<20060316082951.58592fdc.rdunlap@xenotime.net>
	<20060316163001.GA7222@infradead.org>
Organization: YPO4
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1002
Lines: 27

On Thu, 16 Mar 2006 16:30:01 +0000 Christoph Hellwig wrote:

> On Thu, Mar 16, 2006 at 08:29:51AM -0800, Randy.Dunlap wrote:
> > On Thu, 16 Mar 2006 16:01:30 +0000 Christoph Hellwig wrote:
> > 
> > > > The patch implements TRUE and FALSE in include/linux/kernel.h and removes all
> > > > the private versions.
> > > > 
> > > > The patch also kills off a few private implementations of NULL.
> > > 
> > > NACK.  Just kill them all and use 0/1
> > 
> > nah, the only place that using symbolic names for true and false
> > is a problem is when someone #defines or enums them bassackwards.
> 
> it makes the code longer and harder to read.  there's a reason the core
> code doesn't use it, and the periphal code should do the same.

in your opinion.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/