Subject: Re: [patch 1/1] consolidate TRUE and FALSE
From: Xavier Bestel <xavier.bestel@free.fr>
To: Christoph Hellwig <hch@infradead.org>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, aia21@cantab.net,
       len.brown@intel.com
In-Reply-To: <20060316160129.GB6407@infradead.org>
References: <200603161004.k2GA46Fc029649@shell0.pdx.osdl.net>
	 <20060316160129.GB6407@infradead.org>
Content-Type: text/plain
Message-Id: <1142528980.22772.36.camel@capoeira>
Mime-Version: 1.0
Date: Thu, 16 Mar 2006 18:09:40 +0100
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 631
Lines: 19

On Thu, 2006-03-16 at 17:01, Christoph Hellwig wrote:
> > The patch implements TRUE and FALSE in include/linux/kernel.h and removes all
> > the private versions.
> > 
> > The patch also kills off a few private implementations of NULL.
> 
> NACK.  Just kill them all and use 0/1

I'd say use var == 0 and var != 0 (or var and !var).
While FALSE is obviously 0, TRUE isn't only 1.

	Xav


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/