Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 2/3] extcon: max14577: Add proper dt-compatible
 strings
From:   Marek Szyprowski <m.szyprowski@samsung.com>
To:     Chanwoo Choi <cw00.choi@samsung.com>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Krzysztof Kozlowski <krzk@kernel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Sebastian Reichel <sre@kernel.org>,
        Mark Brown <broonie@kernel.org>
Message-ID: <e3c55c02-4d9f-f19c-2cd8-42f6a85f348d@samsung.com>
Date:   Fri, 22 May 2020 11:20:27 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
        Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <a1f499fa-1907-93f5-6f57-13187ae10d7e@samsung.com>
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20200522064801.16822-1-m.szyprowski@samsung.com>
        <CGME20200522064807eucas1p2665d6b3928b2ad515abe54513cbd7fd8@eucas1p2.samsung.com>
        <20200522064801.16822-2-m.szyprowski@samsung.com>
        <8ec0c604-8cdc-04f8-fc5c-fd967f52022b@samsung.com>
        <a1f499fa-1907-93f5-6f57-13187ae10d7e@samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi

On 22.05.2020 10:30, Marek Szyprowski wrote:
> Hi Chanwoo,
>
> On 22.05.2020 09:08, Chanwoo Choi wrote:
>> On 5/22/20 3:48 PM, Marek Szyprowski wrote:
>>> Add device tree compatible strings and create proper modalias 
>>> structures
>>> to let this driver load automatically if compiled as module, because
>>> max14577 MFD driver creates MFD cells with such compatible strings.
>>>
>>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>>> ---
>>> v2:
>>> - added .of_match_table pointer
>>> ---
>>>   drivers/extcon/extcon-max14577.c | 10 ++++++++++
>>>   1 file changed, 10 insertions(+)
>>>
>>> diff --git a/drivers/extcon/extcon-max14577.c 
>>> b/drivers/extcon/extcon-max14577.c
>>> index 32f663436e6e..03af678ddeba 100644
>>> --- a/drivers/extcon/extcon-max14577.c
>>> +++ b/drivers/extcon/extcon-max14577.c
>>> @@ -782,9 +782,19 @@ static const struct platform_device_id 
>>> max14577_muic_id[] = {
>>>   };
>>>   MODULE_DEVICE_TABLE(platform, max14577_muic_id);
>>>   +static const struct of_device_id of_max14577_muic_dt_match[] = {
>>> +    { .compatible = "maxim,max77836-muic",
>>> +      .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
>>> +    { .compatible = "maxim,max14577-muic",
>>> +      .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
>>> +    { },
>> How about changing the order between max77836 and max14577 as already 
>> added structure
>> like platform_device_id if there are no specific reason as following:?
>>
>>
>> static const struct of_device_id of_max14577_muic_dt_match[] = {
>>     { .compatible = "maxim,max14577-muic",
>>       .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
>>     { .compatible = "maxim,max77836-muic",
>>       .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
>>     { },
>
> Sure. I will swap them and send updated patch. This order comes from 
> drivers/power/supply/max14577_charger.c, which also lacks 
> .of_match_table, so I will also fix it.
It looks that I've checked a wrong tree. I will send v3 with 
of_match_table sorted. I have no idea why the order is reversed.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland