Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200521142047.169334-1-elver@google.com> <20200521142047.169334-4-elver@google.com>
 <20200522102630.GC28750@zn.tnic>
In-Reply-To: <20200522102630.GC28750@zn.tnic>
From:   Marco Elver <elver@google.com>
Date:   Fri, 22 May 2020 12:34:00 +0200
Message-ID: <CANpmjNM=aHuTWFk45j8BwRFoTQxc-ovghjfwQr5m4K3kVP8r0w@mail.gmail.com>
Subject: Re: [PATCH -tip v3 03/11] kcsan: Support distinguishing volatile accesses
To:     Borislav Petkov <bp@alien8.de>
Cc:     "Paul E. McKenney" <paulmck@kernel.org>,
        Dmitry Vyukov <dvyukov@google.com>,
        Alexander Potapenko <glider@google.com>,
        Andrey Konovalov <andreyknvl@google.com>,
        kasan-dev <kasan-dev@googlegroups.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Will Deacon <will@kernel.org>,
        clang-built-linux <clang-built-linux@googlegroups.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 22 May 2020 at 12:26, Borislav Petkov <bp@alien8.de> wrote:
>
> On Thu, May 21, 2020 at 04:20:39PM +0200, Marco Elver wrote:
> > diff --git a/scripts/Makefile.kcsan b/scripts/Makefile.kcsan
> > index 20337a7ecf54..75d2942b9437 100644
> > --- a/scripts/Makefile.kcsan
> > +++ b/scripts/Makefile.kcsan
> > @@ -9,7 +9,10 @@ else
> >  cc-param =3D --param -$(1)
> >  endif
> >
> > +# Keep most options here optional, to allow enabling more compilers if=
 absence
> > +# of some options does not break KCSAN nor causes false positive repor=
ts.
> >  CFLAGS_KCSAN :=3D -fsanitize=3Dthread \
> > -     $(call cc-option,$(call cc-param,tsan-instrument-func-entry-exit=
=3D0) -fno-optimize-sibling-calls)
> > +     $(call cc-option,$(call cc-param,tsan-instrument-func-entry-exit=
=3D0) -fno-optimize-sibling-calls) \
> > +     $(call cc-param,tsan-distinguish-volatile=3D1)
>
> gcc 9 doesn't like this:
>
> cc1: error: invalid --param name =E2=80=98-tsan-distinguish-volatile=E2=
=80=99
> make[1]: *** [scripts/Makefile.build:100: scripts/mod/devicetable-offsets=
.s] Error 1
> make[1]: *** Waiting for unfinished jobs....
> cc1: error: invalid --param name =E2=80=98-tsan-distinguish-volatile=E2=
=80=99
> make[1]: *** [scripts/Makefile.build:267: scripts/mod/empty.o] Error 1
> make: *** [Makefile:1141: prepare0] Error 2
> make: *** Waiting for unfinished jobs....
>
> git grep "tsan-distinguish-volatile" in gcc's git doesn't give anything.
>
> Hmm.

Yeah, my patch for GCC is still pending. But we probably need more
fixes for GCC, before we can re-enable it.

We restrict supported compilers later in the series:
https://lore.kernel.org/lkml/20200521142047.169334-7-elver@google.com/

More background is also in the cover letter:
https://lore.kernel.org/lkml/20200521142047.169334-1-elver@google.com/

Thanks,
-- Marco