Received: by 2002:a25:1104:0:0:0:0:0 with SMTP id 4csp182354ybr; Fri, 22 May 2020 04:11:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEX8uTdjgs9p/IluAJUU118LYmyQAjt+EEP3SkxNwIsAGXc/t1aoDrXQ5gjVYi1LwkB55B X-Received: by 2002:a17:906:4d9a:: with SMTP id s26mr7355457eju.153.1590145898022; Fri, 22 May 2020 04:11:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590145898; cv=none; d=google.com; s=arc-20160816; b=Zo3pFZo1IhctB/ywRB63gP6Ixp16yXM8NR5WP9v87ZVOXYAdtn3/62pyDMKxYlA1vV XG1dBTeESG4s6Ao1b5m/9lkJQZPb5BOHLT44By0BFuz3Iw5VEm6R0rhRxnQwZhXOKOB9 1r9XSdktFbMa1oWgv4zV51KXGYQQzgDaRxH07WTjlHj8SWa31G7mxys8iJdcf8VzxQtx Wbfw4JKqeVwuetyESNDvLQSzJUbfcac4OfPRp8mUFhCK1QGS7CO3gROeAajd+/GCWzjq 3yJeTv/cV7IKSkQJjVVr4n0ZYzCw01MP1r1SVcDW67oSMN8EtNKVVMgmIpLzODMG7+Qh c4pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=akm9w9vUGMm1OZtMoY9+dDiEUBKGQg7DabJxbnXOXDY=; b=z73D2KNhLdcTdM5T+QVmXeGH/38yqEBdqTPS/pzEX4nPeeXV9pyrZNUrPWyfHqzu5O 87IUYWXsjZRvM9hQcwUpZCHyTEpuaTmkVqXV8nMOA+gG4C4A3rYwzVfokf7SAO+pTs+T jx0hG1voq/ailbO6zzct1RLnglqFU4YiRXfB+JJsoZ3Svou+RE+LHhaBrak8hwIs/ICx Tn850z5ysQrHuKmvSbtWJp2AhLKpn2IXlu5wmX0gIAiR6NjR46EJsdt2ZIVlI/hZc+S4 qN6DYuYBvLNwmGXB0hJeG65vrdQQx0zSddfTrngHAINsbKKhHeVj+2ssl/J+xKpqeSNb 32cA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jrMoWA3n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m21si4594165edb.534.2020.05.22.04.11.13; Fri, 22 May 2020 04:11:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jrMoWA3n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729382AbgEVLJH (ORCPT + 99 others); Fri, 22 May 2020 07:09:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:60338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728281AbgEVLJG (ORCPT ); Fri, 22 May 2020 07:09:06 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BDBEF206B6; Fri, 22 May 2020 11:09:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590145746; bh=akm9w9vUGMm1OZtMoY9+dDiEUBKGQg7DabJxbnXOXDY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jrMoWA3nOKs2MGjrLolal+vz6NUhgpGFJzvHoE/v9U3gXwsd7UVDpQNjCRJh3RRa0 0q90IBErHUS/9YGzSoj2wGN02Si616FepPxOKgt3xUZPQjgEY8KS/rwSl9ynOi3mM1 eFY+PXz4pJ5vT7Ld/aSDfVHhIjo5AnFOHEJWQmOM= Date: Fri, 22 May 2020 12:09:03 +0100 From: Mark Brown To: Marek Szyprowski Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Chanwoo Choi , MyungJoo Ham , Sebastian Reichel Subject: Re: [PATCH v3 1/3] regulator: max14577: Add proper dt-compatible strings Message-ID: <20200522110903.GC5801@sirena.org.uk> References: <20200522102448.30209-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5QAgd0e35j3NYeGe" Content-Disposition: inline In-Reply-To: <20200522102448.30209-1-m.szyprowski@samsung.com> X-Cookie: C for yourself. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5QAgd0e35j3NYeGe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 22, 2020 at 12:24:46PM +0200, Marek Szyprowski wrote: > Add device tree compatible strings and create proper modalias structures > to let this driver load automatically if compiled as module, because > max14577 MFD driver creates MFD cells with such compatible strings. Same issue as before, you're putting the current Linux model into DT without adding any additional description of the hardware. --5QAgd0e35j3NYeGe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7Hss8ACgkQJNaLcl1U h9DIJgf7BpDKzpW22MjREOy/41/5TdMCG7vybW18iFY8cHBhBjkkP/8J24jCBWS4 9MQsT4JKH4gJyZANrjPM79ARiUiSH2GIpfBieUoMVEqcoHF2IsQobLgVbji2BXHH m8CZooQ9v5ayNjkIvXUvnJE6Dm4ynGcoeOnyQ5xoV+o2QJlcXkdARQgYll1DQsgj QO0iqLxLGzRM3VkNlZkQ7d3dz8i8ZTnwotJesCoLL1f0dm318aHCLZPC8bAyUI6w r7A6uxjbo05r0q8JApVUc5MoavmnIsT3samcO+RsNqh5VvfLkWoc4kDNey92eJ86 hdvteo+Qp9VPvmvdlDTfvCtdfVV89w== =IFlK -----END PGP SIGNATURE----- --5QAgd0e35j3NYeGe--