Received: by 2002:a25:1104:0:0:0:0:0 with SMTP id 4csp212504ybr; Fri, 22 May 2020 05:01:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1ESjS6rgH8pqzv2MaODJOH7PRDFx0Q1QD9pMIf9D2mFFNgcCEN1rEQOFLOAG7LKWz0rsv X-Received: by 2002:a17:906:409:: with SMTP id d9mr7529619eja.445.1590148864695; Fri, 22 May 2020 05:01:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590148864; cv=none; d=google.com; s=arc-20160816; b=ZFJ+PabV65gnW0K84zbUdKGMuKQJuEcJxIDvPfAOrN+oA30Jcz/HwOYd6FTK0oVPuA E5xsD1G8/wFzP8U7fPFL952LC8cbumZs6z8baXmTksdaPuMWG40duCXwgd+LiF9IjYYO Zu5uIaxXT/2/iV1heTQrtw+tShQoIZ3aEqUEmAZIa/i88pcsLt2TQdtNyi0501fhEmfD +JsthKnaML4hkhX5WMNBSI7IMQC2Db0UnTpvFH1HzQvjHbcUuC2pBepsFj76KNjbf/Kg MHoj7Atj0tDkgmRkwPH7Nh6R1BH3hdJHVS2mwazG4Ldqg4beydA+K3RkjewtJELzSZ5g ldgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature; bh=fsJxXs8/dXjYa6fAo5MdTVonpyH/JuFRjIc5f4aYvL4=; b=OQWE6kggk/NcnykeKUVEtEZ6gAeaoyNHl8JWOAz05BUlM4J12ykqvti+wUXow3f/fF C165+aSaYdlfT+zQ3gaZ+UHwnW0JKZ+0p/k/ynV8Nd2odYYpS15su89Ycfiogj93Upw8 stB1sp3e6j7irupaafjpk9VNr8VWRXmBvNGnuRMSWklCk5XExKfId3dWEc5rWpYc5S2r lshqSd8niqXY2a1TbGyCzBTcf2uSn9zPq8N0J5/kVsTAgsUt/RDfbOHEyoPsC12NjNUw d/7ktI79Mbk5e2BxfVQwi1k/sw/fMex8jOuM/uT2SgDYYTimFyhdeaiwE5oAMuzSizZC Ukaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b="BRa2VLN/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w13si4425973edf.228.2020.05.22.05.00.40; Fri, 22 May 2020 05:01:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b="BRa2VLN/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729047AbgEVL6n (ORCPT + 99 others); Fri, 22 May 2020 07:58:43 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:56133 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728629AbgEVL6n (ORCPT ); Fri, 22 May 2020 07:58:43 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1590148722; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=fsJxXs8/dXjYa6fAo5MdTVonpyH/JuFRjIc5f4aYvL4=; b=BRa2VLN/jaARgTLuP5yszxjrcmEsuGDuYjMkOs0OybPhdnAiix5Z6It9NoWzMTLIKysaEOjl yMBlP9CKfYDyEpvvhUslEN2rDZdKMrc+LLwFvQ+QwdQ4tg0sH8zUnjKFQIkoOlByo1o/pyPa eUihpbU7zdVodLHsSkGSWDVbWcM= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 5ec7be72e79e24225dc33a48 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 22 May 2020 11:58:42 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 43E9BC43395; Fri, 22 May 2020 11:58:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from [192.168.1.102] (unknown [157.44.159.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jprakash) by smtp.codeaurora.org (Postfix) with ESMTPSA id 49E81C433C8; Fri, 22 May 2020 11:58:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 49E81C433C8 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=jprakash@codeaurora.org Subject: Re: [PATCH V4 4/5] iio: adc: Update error checks and debug prints To: Andy Shevchenko Cc: agross@kernel.org, Bjorn Andersson , devicetree , Linux Kernel Mailing List , Matthias Kaehlcke , Linus Walleij , Jonathan Cameron , Amit Kucheria , smohanad@codeaurora.org, kgunda@codeaurora.org, aghayal@codeaurora.org, Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-arm-msm@vger.kernel.org, linux-iio , linux-arm-msm-owner@vger.kernel.org References: <1589361736-816-1-git-send-email-jprakash@codeaurora.org> <1589361736-816-5-git-send-email-jprakash@codeaurora.org> From: Jishnu Prakash Message-ID: <9accb386-0b4c-ca3c-09e9-c2610ea20bfa@codeaurora.org> Date: Fri, 22 May 2020 17:28:32 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On 5/13/2020 3:19 PM, Andy Shevchenko wrote: > On Wed, May 13, 2020 at 12:23 PM Jishnu Prakash wrote: >> Change pr_err/pr_debug statements to dev_err/dev_dbg for >> increased clarity. Also clean up some return value checks. > 'Also' on the commit message == 'split this to two'. I'll do the ret value changes in the third patch in my next post, according to your comment there. > But here is a ping pong style of patches (you introduce a problem in > one patch and fix it in the following). I'll try to avoid this in the next post >