Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 3/3] selftests: vdso: Add a selftest for vDSO getcpu()
To:     Mark Brown <broonie@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        shuah <shuah@kernel.org>
References: <20200505174728.46594-1-broonie@kernel.org>
 <20200505174728.46594-4-broonie@kernel.org>
 <dff4dfbd-f3f1-d683-5dac-4404e9023b2e@kernel.org>
 <20200519174452.GR4611@sirena.org.uk>
From:   shuah <shuah@kernel.org>
Message-ID: <0f1a7c29-340d-f61b-b102-d300932dc92c@kernel.org>
Date:   Fri, 22 May 2020 08:55:50 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200519174452.GR4611@sirena.org.uk>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 5/19/20 11:44 AM, Mark Brown wrote:
> On Tue, May 19, 2020 at 11:11:28AM -0600, shuah wrote:
>> On 5/5/20 11:47 AM, Mark Brown wrote:
> 
>>> +int main(int argc, char **argv)
>>> +{
>>> +	unsigned long sysinfo_ehdr = getauxval(AT_SYSINFO_EHDR);
>>
>> WARNING: Missing a blank line after declarations
>> WARNING: Missing a blank line after declarations
>> #135: FILE: tools/testing/selftests/vDSO/vdso_test_getcpu.c:27:
>> +	unsigned long sysinfo_ehdr = getauxval(AT_SYSINFO_EHDR);

A blank line after declarations here just like what checkpatch
suggests. It makes it readable.

>> +	if (!sysinfo_ehdr) {
> 
> This is the idiom in use by the existing gettimeofday test:
> 
> WARNING: Missing a blank line after declarations
> #38: FILE: tools/testing/selftests/vDSO/vdso_test_gettimeofday.c:38:
> +	unsigned long sysinfo_ehdr = getauxval(AT_SYSINFO_EHDR);
> +	if (!sysinfo_ehdr) {
> 
> so I don't know how you want the code to look here?
> 

See above.

thanks,
-- Shuah