Received: by 2002:a25:1104:0:0:0:0:0 with SMTP id 4csp354528ybr; Fri, 22 May 2020 08:11:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBSb04ELPM2TFplIuCErMy5qnGDN6P+clpWUBi/N1b7IZiGkmyiZ84wNpWGucCfWh6Xchi X-Received: by 2002:a17:906:1746:: with SMTP id d6mr3200173eje.34.1590160314841; Fri, 22 May 2020 08:11:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590160314; cv=none; d=google.com; s=arc-20160816; b=ULQ7rteFwNQVdqtHiSt+whz9H6U++x4l5JqDUOscynuRltPvOG/QBgQkCgEHsRpKcD nnPuu1+eRuBzIoBzh84xLUdlskIl5+OyvXpVAquOgjG/Bu7vbOoRDpAnS9qZ+RR3/67y 5P2CZl5IXtaX/LQE3qknAlIoYEdVRSCc3SdCI7eUinsApznwXCfjMGs5R3uzwj38efjE oitP6vMfmTyMiSDOeUCihcUM2Y+SoWJ6QXxjAqZRIWfOee4k+9RHNS31hp+4WRSMw+Il Aqq+y97L/boloooL/cSXJ9xdTtWYcu85l3NHidI/0TCA5Y2ydakxHuuu2/fnZXEsYgml 9GMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=O4JxMoxqpD+qsOnpVuK88JlN15d1+AmRm4bNPhcXni4=; b=mHsnIjwfugY8qYphwl0HwxzGbstJ4dSIZM3etadE8014Uj8mqMv7wZRC14RuPqo7qx xf030jOAWY+0LCHeBx50hNJiRdp66Q606I7qHfjaQZ8jvJleCst7lBD4n5v/E7QL3t2b YhgHSm1jEFRKmtSpuUYwEUguB17t4c1jpxBNz9Ao6Q0c6oVDazTFYKt8L5QploMVb/Ew wapLQY+0PWxIK6c006ocr4N4mNpHMdkDjYVD5QcRWG4Bi/fvlAFQ3D8LAkZuEgCksu// tLBshgRNRG7s5+ytIrOMdDmhvVEMN5I7TSuLAfw/0W47jcD6v7RTo6reugsrOSB8JM9S Pobg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o22si881129ejx.452.2020.05.22.08.11.31; Fri, 22 May 2020 08:11:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730212AbgEVPHl (ORCPT + 99 others); Fri, 22 May 2020 11:07:41 -0400 Received: from sauhun.de ([88.99.104.3]:33376 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729931AbgEVPHl (ORCPT ); Fri, 22 May 2020 11:07:41 -0400 Received: from localhost (p5486cea4.dip0.t-ipconnect.de [84.134.206.164]) by pokefinder.org (Postfix) with ESMTPSA id 5B27A2C2071; Fri, 22 May 2020 17:07:39 +0200 (CEST) Date: Fri, 22 May 2020 17:07:39 +0200 From: Wolfram Sang To: Tang Bin Cc: o.rempel@pengutronix.de, u.kleine-koenig@pengutronix.de, ardb@kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Shengju Zhang Subject: Re: [PATCH] i2c: drivers: Avoid unnecessary check in efm32_i2c_probe() Message-ID: <20200522150738.GH5670@ninjato> References: <20200415140640.19948-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pfTAc8Cvt8L6I27a" Content-Disposition: inline In-Reply-To: <20200415140640.19948-1-tangbin@cmss.chinamobile.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pfTAc8Cvt8L6I27a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 15, 2020 at 10:06:40PM +0800, Tang Bin wrote: > The function efm32_i2c_probe() is only called with an > openfirmware platform device.Therefore there is no need > to check that it has an openfirmware node. >=20 > Signed-off-by: Tang Bin > Signed-off-by: Shengju Zhang Applied to for-next, thanks! I agree the driver will need additions for non-DT platforms anyhow, so greeting with an OOPS is kinda suitable, too ;) --pfTAc8Cvt8L6I27a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl7H6roACgkQFA3kzBSg KbYkIw/7BqnJb/EWR5Blh3d4vpx3rtS8kwGxEIY4UbtTq1uWotMuzrDKdwyDMIXV i6nooV/NJ0Eib6pVtQQLz6VVquUA1s0SVHR6vwN2CTZIZIHtntwHUflDkE7ViR1M o7eGs9UUmEUvedljeQFcl+t5Qbx54i5kHSqP6x1KoHJJCQzmz8f6dAfSVR82B859 byP1J7Nb8TzilTSKdfl3eV0jXomazoHUvxYUvIeM8t9Lm8GL6k/6NMIWKXfGQiff 55kuYKhRaFfX+A5ZigPA4gmvP4hdGAomLr0aQePMwlQljWUoJVvyLF5olRONAhB9 TkMUsC6xLbOh10hfknqsdJD1krFHvX+AM8EpsZ6E0dnsGxq4Ns2JTSod5rs8S0Qq dGf4pb62qWAy7xY/Gc6wrxwG+mdniZMXxCtw9arDdgRTebm3+bBVSNB7V4LrC88w hLsjWC/X3KGvXWOiNx3hVLn/+sXzZum2vk/M0UMW3mItW9yozI0z+BxT8Rcqd/7+ iHcxarj8nHn2TYnqoN6lRe1mliqkPA3OmTUvgRQF99W+0xFhD9h7sVEr+Ri3gJfw +arI0O1tKeTidUDXLazDPM94NQR4wLaBmee/Q8kUKCoIbYeYpSU3AKQlZHJkrSpQ FKFgszHQaQS2aCh27SDp0/cvSlrQwokVi5S2ri5lZc4XLylgltw= =JDIx -----END PGP SIGNATURE----- --pfTAc8Cvt8L6I27a--