Received: by 2002:a25:1104:0:0:0:0:0 with SMTP id 4csp356442ybr; Fri, 22 May 2020 08:14:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIezgQ8MJX3F4BETyjquFc/UxSlC/7/0huqMNaxM+cWMlWpnaUamwZK2MhzkfbEItbzDG+ X-Received: by 2002:a50:c94d:: with SMTP id p13mr3421193edh.240.1590160474983; Fri, 22 May 2020 08:14:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590160474; cv=none; d=google.com; s=arc-20160816; b=W30ybDh7xB2nGGt5he/djHEOl75N4OEEWfGIhaaUvabO9O9soh0eOOMt9EnUn3KZud ecc5Kx7z5ubJZzYScC4eYBkvUkcNwt4tlCpDmhKK2LO8lRS3lvO7vhRflAWh0zTnTR6N F9+Dt6KCtqJqCjST8jy2goOTvzrj1bNv3Z6BxJebcvTdrICh+WSnh01r72Xyl1+lYKS2 /IBfe35ssSg1VVtxMJfG791m1bGNaggnvm5wB5Z0lZXhjxEE0OZuZQ8nFMlXkp5Yj9wF zeXPn5hhXMqOl11+qEUaKbmw3eJWWCQ+1VFCgnlpEO9KngqsXiPpkYP/P02ihdnYeK0r Xy7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=NpIxzFQZhwzsG35Fa2tb54URJCuusuACHuAm7+BMNbE=; b=M9oOrZJbN19+EufvTJZi1/svV2NarRxBUKVcU+sz1qswLg4bfshjvebgGS9QuZlCkh 6y8pz+i2thFuVk3a2EvdbQ+G+v2OnH+zP7/axbzlsc1LikysPW6MI/rPuBCiSM3j2BR4 UqnZXjyJ5Xfj2JJA5CO6iiW0HuzuVi9agSePFzcH34krSnwL5o36SU0bV05JCPqAcNuA MU8WsVFmj5aVylcXR3xdMD/gR9WF7JGHN70kW+/oFNzizroaAm/lXOtCfJTDGj94Vmgg IrY4lFB4PehyuNS9D+J5En8iQO42CDc/HemOfAjLFfuIRpXf2uZMrI8rk3qzGf8UB/z8 sQ6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sY558fod; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z2si5059194eja.516.2020.05.22.08.14.11; Fri, 22 May 2020 08:14:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sY558fod; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730251AbgEVPM0 (ORCPT + 99 others); Fri, 22 May 2020 11:12:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:38882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729929AbgEVPMZ (ORCPT ); Fri, 22 May 2020 11:12:25 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A18C4205CB; Fri, 22 May 2020 15:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590160345; bh=nS0h4RozeqQ2zDT71/b8HIMFM/1uZWrd6rex05YnTj4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sY558fodh/SGqJTWRlnQq3JYI5dRHMV1MoEJNk/S989jp6HWgrNsREbRSFe2aTuxB bMR7hBan+N2rk4xcNKv7mH/sfCbQXcnBUxUfcPppUYJ1oCrRsU6hv0XkYniQdx3mcZ oKD065rICV/tvZ/KylRYjYy4A1m4yUV+N0O7zcLY= Date: Fri, 22 May 2020 16:12:22 +0100 From: Mark Brown To: shuah Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 3/3] selftests: vdso: Add a selftest for vDSO getcpu() Message-ID: <20200522151222.GJ5801@sirena.org.uk> References: <20200505174728.46594-1-broonie@kernel.org> <20200505174728.46594-4-broonie@kernel.org> <20200519174452.GR4611@sirena.org.uk> <0f1a7c29-340d-f61b-b102-d300932dc92c@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yr/DzoowOgTDcSCF" Content-Disposition: inline In-Reply-To: <0f1a7c29-340d-f61b-b102-d300932dc92c@kernel.org> X-Cookie: C for yourself. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yr/DzoowOgTDcSCF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 22, 2020 at 08:55:50AM -0600, shuah wrote: > On 5/19/20 11:44 AM, Mark Brown wrote: > > > WARNING: Missing a blank line after declarations > > > WARNING: Missing a blank line after declarations > > > #135: FILE: tools/testing/selftests/vDSO/vdso_test_getcpu.c:27: > > > + unsigned long sysinfo_ehdr = getauxval(AT_SYSINFO_EHDR); > A blank line after declarations here just like what checkpatch > suggests. It makes it readable. That doesn't match the idiom used by any of the surrounding code :( --yr/DzoowOgTDcSCF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7H69UACgkQJNaLcl1U h9CYvAf+Oop8av99Ht92WyMXd28H0tQSfKAthADXU3g0Gr/J9LiaWJcY0xxlsOQZ RkDr5YaYBi2Sy3Hq+W+cIekf52aFNIB/z1f18r8Nlsf4BbhrktPRj/jL7auo90vL PckxqeCOTpYxL+Pd+WsjZWj8ow82l76fQGBDFAX1ycNsbLt4xHw6iHqrShKZnYGc ZMe/Ky0Y6HqLYAoZA9q+AsDOlSajH+Qx6FnNc6t90tmrmY0WRVHCWgj2f8K7eVlN 6bQR8ZFiI3uSzMdO9PdUFIWyVEIbAI6jxYNFroALJfxeyz0MIkcQpYQfMwKUgxEs U7rCjlgnhEUd5GmTPuIs8OmCZc4mGA== =549M -----END PGP SIGNATURE----- --yr/DzoowOgTDcSCF--