Received: by 2002:a25:1104:0:0:0:0:0 with SMTP id 4csp407148ybr; Fri, 22 May 2020 09:23:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEPeN8uY09FENVmfDWEI2MtGa+DtaRMAtz/1GjX8CY2CKz9NSCLcwZm1uULfo4QlATY9Uk X-Received: by 2002:a17:906:9404:: with SMTP id q4mr8728290ejx.138.1590164600789; Fri, 22 May 2020 09:23:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590164600; cv=none; d=google.com; s=arc-20160816; b=jz1Mr+DvMIp4Htvyr0Gnm3eHIaDT6qsTCSuRFB1A/J7t8QUXcAtYt7+7Jdp+yHnq61 U7jZKRPkHUajpOVxqLCmNnzXe2UmEqTEwFf3BmurhcaqoFyMOsN1F/OmtZcKmzk673Ot eUNWikcB2YlTGACvjSsZK4byQLJ0G6NiSGEVaF+owLGU+dCwO8soXMW50DSKnHTaBEqI q31m6RNT2ScxadKE2xrcXWfvstRD8s9RvEJtfAbgxPkiOnO1wwAGGSyhbqNQcpyfL18+ uIZARxtlEx1r4wohpg7jgns8Ma/o0OzWtd9e6qkwmcjyQnDfOByHmw0q6TLDfTfZUsDw rKCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=oCM0Dq8EtMmFJOoiFoa3ONVKt/yhzn8rHg5EOI7nn68=; b=P/3Yr52cTckxXg/ObS1lqttsZELUf4ilcO1nTb1z6hljMefpAb6FOznMbhAJbJcLSF NKn+Ya4Xzl1HNb/pVHCjcLcNcZTqTUwBv5423fys0G7GdIKXVxN/JoIIC7XNHI9AyCez 0YdUR2sucBmZoUyF8/i1fxsTOieK1rpZuuAat+DZLLhknpehPvtet1HSLugu2q2yI7DN EbJPRxAsJmoJO4BZVGyR/RRfoheZ7haUG3wa2kRs/28th2bnU7SIJSuw00WVgSm3p3WT lDET4iUhv29HDHjkqU9feLBUbYELNPPb7o2gyEVXeIkHWQamsqp0l/D8sLHohx9AoB18 PZYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w14si4676226ede.41.2020.05.22.09.22.56; Fri, 22 May 2020 09:23:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730273AbgEVQVS (ORCPT + 99 others); Fri, 22 May 2020 12:21:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:37766 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729040AbgEVQVS (ORCPT ); Fri, 22 May 2020 12:21:18 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 03F0DB27C; Fri, 22 May 2020 16:21:18 +0000 (UTC) Date: Fri, 22 May 2020 18:21:13 +0200 From: Petr Mladek To: Kees Cook Cc: Pavel Tatashin , Anton Vorontsov , Colin Cross , Tony Luck , Jonathan Corbet , Benson Leung , Rob Herring , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Enric Balletbo i Serra , Sergey Senozhatsky , Steven Rostedt , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v4 1/6] printk: Collapse shutdown types into a single dump reason Message-ID: <20200522162113.GK3464@linux-b0ei> References: <20200515184434.8470-1-keescook@chromium.org> <20200515184434.8470-2-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200515184434.8470-2-keescook@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 2020-05-15 11:44:29, Kees Cook wrote: > To turn the KMSG_DUMP_* reasons into a more ordered list, collapse > the redundant KMSG_DUMP_(RESTART|HALT|POWEROFF) reasons into > KMSG_DUMP_SHUTDOWN. The current users already don't meaningfully > distinguish between them, so there's no need to, as discussed here: > https://lore.kernel.org/lkml/CA+CK2bAPv5u1ih5y9t5FUnTyximtFCtDYXJCpuyjOyHNOkRdqw@mail.gmail.com/ > > Signed-off-by: Kees Cook Looks good to me: Reviewed-by: Petr Mladek Best Regards, Petr