Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 22 May 2020 14:26:15 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Andy Lutomirski <luto@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Alexandre Chartre <alexandre.chartre@oracle.com>,
        Frederic Weisbecker <frederic@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Petr Mladek <pmladek@suse.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        Juergen Gross <jgross@suse.com>,
        Brian Gerst <brgerst@gmail.com>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Will Deacon <will@kernel.org>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Wei Liu <wei.liu@kernel.org>,
        Michael Kelley <mikelley@microsoft.com>,
        Jason Chen CJ <jason.cj.chen@intel.com>,
        Zhao Yakui <yakui.zhao@intel.com>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>
Subject: Re: [patch V6 19/37] x86/irq: Convey vector as argument and not in
 ptregs
Message-ID: <20200522192615.5asnbnanfdiofaj6@treble>
References: <87sgfttobg.fsf@nanos.tec.linutronix.de>
 <f3be26a9-a0ed-fc6c-f25c-3fd41e718292@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <f3be26a9-a0ed-fc6c-f25c-3fd41e718292@oracle.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, May 22, 2020 at 02:48:53PM -0400, Boris Ostrovsky wrote:
> > Yes. They just make objtool very unhappy:
> >
> > arch/x86/entry/entry_64.o: warning: objtool: .entry.text+0xfd0: special:
> > can't find orig instruction
> >
> > Peter suggested to use:
> >
> >       .pos = .
> >       .byte..
> >       jmp
> >       .nops (pos + 8) - .
> 
> 
> Unfortunately this (.nops directive) only works for newer assemblers
> (2.31, per
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob_plain;f=gas/NEWS;h=9a3f352108e439754688e19e63a6235b38801182;hb=5eb617a71463fa6810cd14f57adfe7a1efc93a96)
> 
> 
> I have 2.27 and things don't go well.

A single nop should be fine, since gas will complain if it tries to move
the IP backwards.  (Also I'd vote for normal indentation instead of the
"assembler magic at 4 spaces" thing.)

.align 8
SYM_CODE_START(irq_entries_start)
	vector = FIRST_EXTERNAL_VECTOR
	.rept (FIRST_SYSTEM_VECTOR - FIRST_EXTERNAL_VECTOR)
		pos = .
		UNWIND_HINT_IRET_REGS
		.byte	0x6a, vector
		jmp	asm_common_interrupt
		nop
		.  = pos + 8
		vector = vector + 1
	.endr
SYM_CODE_END(irq_entries_start)

-- 
Josh