Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200520040221.10536-1-qiang.zhao@nxp.com> <20200520040221.10536-2-qiang.zhao@nxp.com>
In-Reply-To: <20200520040221.10536-2-qiang.zhao@nxp.com>
From:   Li Yang <leoyang.li@nxp.com>
Date:   Fri, 22 May 2020 14:38:47 -0500
Message-ID: <CADRPPNQEA1R6Ef=2r1w+KhUsKi2=_aJtFqrKO+Nj+b0WAyEVeQ@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] arm64: dts: Add ds26522 node to dts to ls1043ardb
To:     Qiang Zhao <qiang.zhao@nxp.com>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, May 19, 2020 at 11:08 PM Qiang Zhao <qiang.zhao@nxp.com> wrote:
>
> From: Zhao Qiang <qiang.zhao@nxp.com>

Maybe remove the duplicated dts in the title?

>
> Add ds26522 node to fsl-ls1043a-rdb.dts
>
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> v3:
>  - use "arm64: dts:" format for subject
>
> arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> index 44d9343..1cb265f 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
> @@ -94,6 +94,22 @@
>                 reg = <0>;
>                 spi-max-frequency = <1000000>; /* input clock */
>         };
> +
> +       slic@2 {

If this is a plugin card for the board, will this cause any problem
when the card is not plugged in?

> +               compatible = "maxim,ds26522";
> +               reg = <2>;
> +               spi-max-frequency = <2000000>;
> +               fsl,spi-cs-sck-delay = <100>;
> +               fsl,spi-sck-cs-delay = <50>;
> +       };
> +
> +       slic@3 {
> +               compatible = "maxim,ds26522";
> +               reg = <3>;
> +               spi-max-frequency = <2000000>;
> +               fsl,spi-cs-sck-delay = <100>;
> +               fsl,spi-sck-cs-delay = <50>;
> +       };
>  };
>
>  &duart0 {
> --
> 2.7.4
>