Received: by 2002:a25:1104:0:0:0:0:0 with SMTP id 4csp633989ybr; Fri, 22 May 2020 15:24:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyD3sDd6KJyhnE5iCBBzuG8Sr2Q62Bo/vT0x4+lJlnWbotZjCZqPDW20aCzDnTid58vig7m X-Received: by 2002:a17:906:4353:: with SMTP id z19mr10771568ejm.371.1590186291080; Fri, 22 May 2020 15:24:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590186291; cv=none; d=google.com; s=arc-20160816; b=k9I88H/Lm4DThYFUdHw/P6Jgm/guDodYHB7AHMfK1EzQ33ImeiOIm/BXAy8qmL04w+ VFJKaAdU3ijbYLKip/NPK38sBC4zfK05z6cU0hR0vb5O3EKDRuAmM6eartb/+aoE3ExE Lab7+wxffWE3xtakizqUtuEQDPpxwXln3jhfxHrK91/4nz74R2zJZcfeh2hfp+KCO9L4 obLMFStCrCTC51DLquJELfHWVnzn4U9Oyv/Hx4CDPyEQDr2Xvvk7a+6IBCdKOK8nkOpS n2fkpRPPm61hQB2BlkOgrVSUu8aVbQFfVdN+K3DEA7jjnut+QlOJ3rubsBnZfW3Apx9w aH2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=O9O6+RtPM2flqTtnO+2Mzi65L6kjI2yOB1OXyUMSITs=; b=PFKbkLHHF5Zg2/d5ZpMg8fIhM2Oih6xTtId2jLDNME0yA4s5HWa0wTHA7irA0Dcim8 ZYCpB1xxsZtJzlLBbXn+nq3sBS/qb4ZFckwItmUD7Dqvm10SOABWITVLTTbjq59uue4X UGqM4FEBygJzXYz9RK9TIm0mTafEnuqoRmbk/zLeL+0oZ0C4PFGfr1qWH1P9X1vGWYNd vja5vaRGlEogrR71b1rdIeHB+ZfLkSgGSxA1WRoNwxgz0OjNoZF8CImOC+vtMmRQ/YEK HvmfmopFlW9kkefQzj3fV7opWum+EGww1ChwETKNKz/5aZ/YN2vCDAV8a6Wiua6+fA5a IctQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=SvLtugFE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o23si5563489ejd.302.2020.05.22.15.24.28; Fri, 22 May 2020 15:24:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=SvLtugFE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731168AbgEVWWN (ORCPT + 99 others); Fri, 22 May 2020 18:22:13 -0400 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:14856 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731111AbgEVWWK (ORCPT ); Fri, 22 May 2020 18:22:10 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 22 May 2020 15:21:58 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 22 May 2020 15:22:10 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 22 May 2020 15:22:10 -0700 Received: from [10.2.52.1] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 22 May 2020 22:22:10 +0000 Subject: Re: [PATCH 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages() To: Souptick Joarder CC: Andrew Morton , Matthew Wilcox , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Chris Wilson , Tvrtko Ursulin , Matthew Auld , , dri-devel , LKML , Linux-MM References: <20200519002124.2025955-1-jhubbard@nvidia.com> From: John Hubbard X-Nvconfidentiality: public Message-ID: <6391e8c2-0b3e-80c3-b59f-63d0fb96bdb4@nvidia.com> Date: Fri, 22 May 2020 15:22:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1590186118; bh=O9O6+RtPM2flqTtnO+2Mzi65L6kjI2yOB1OXyUMSITs=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=SvLtugFEJ9WaldeXt+dm3SwBqigdt2J9ZvySOYhS49EDlHvnhYaJAgLAoVXqC5YKb bUBa8YhbnaSkbR5Y4l4bOQ3nnu1dIp0mpBdCkP/SzdXR1qYCf3zzNXYsSC2gVYVYDG iYC2SSqhenJXAc8846FwAX7sZx8XoXs9r31gd3LHb2erXn5A01u+azAs82iWTVnXrJ aA/TNc7Yd2u3tjbcIsjmovd+ui8GZ1E2HEfpl6ScuUnoZAzwX6Kn6nHc2pRl0wrCHZ 8zYdxnJ3xNNE3XrP82KJ2NOPFJYpmUoSviJP6YoyL/Jk7iQ7wUTdXmvdiHGEE2IS+z lQb8mQnBoAvlA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-05-22 04:40, Souptick Joarder wrote: ... >> 3) Make it easy for an upcoming patch from Souptick, which aims to >> convert __get_user_pages_fast() to use a gup_flags argument, instead >> of a bool writeable arg. Also, if this series looks good, we can >> ask Souptick to change the name as well, to whatever the consensus >> is. My initial recommendation is: get_user_pages_fast_only(), to >> match the new pin_user_pages_only(). > > Shall I hold my changes till 5.8-rc1 , when this series will appear upstream ? I don't really see any problem with your posting something that is based on the latest linux-next (which has my changes now). Should be fine. And in fact it would be nice to get that done in this round, so that the pin* and get* APIs look the same. thanks, -- John Hubbard NVIDIA