Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 22 May 2020 16:07:23 -0700 (PDT)
Message-Id: <20200522.160723.1511383489001652430.davem@davemloft.net>
To:     noodles@earth.li
Cc:     peppe.cavallaro@st.com, alexandre.torgue@st.com,
        joabreu@synopsys.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        adron@yapic.net, marcel@ziswiler.com
Subject: Re: [PATCH] net: ethernet: stmmac: Enable interface clocks on
 probe for IPQ806x
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200521114934.GY311@earth.li>
References: <20200521114934.GY311@earth.li>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Jonathan McDowell <noodles@earth.li>
Date: Thu, 21 May 2020 12:49:34 +0100

> The ipq806x_gmac_probe() function enables the PTP clock but not the
> appropriate interface clocks. This means that if the bootloader hasn't
> done so attempting to bring up the interface will fail with an error
> like:
> 
> [   59.028131] ipq806x-gmac-dwmac 37600000.ethernet: Failed to reset the dma
> [   59.028196] ipq806x-gmac-dwmac 37600000.ethernet eth1: stmmac_hw_setup: DMA engine initialization failed
> [   59.034056] ipq806x-gmac-dwmac 37600000.ethernet eth1: stmmac_open: Hw setup failed
> 
> This patch, a slightly cleaned up version of one posted by Sergey
> Sergeev in:
> 
> https://forum.openwrt.org/t/support-for-mikrotik-rb3011uias-rm/4064/257
> 
> correctly enables the clock; we have already configured the source just
> before this.
> 
> Tested on a MikroTik RB3011.
> 
> Signed-off-by: Jonathan McDowell <noodles@earth.li>

Applied, thanks.