Received: by 2002:a25:d80d:0:0:0:0:0 with SMTP id p13csp171013ybg; Sat, 23 May 2020 10:30:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGmP17BEr0qZaoGO5KGcgkzGUoJJWxr2MJ1t1j7G6Kzdf8hD3gXIMFOgAqYwwLUV6rjOEx X-Received: by 2002:aa7:dd0a:: with SMTP id i10mr7695594edv.291.1590255033572; Sat, 23 May 2020 10:30:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590255033; cv=none; d=google.com; s=arc-20160816; b=ByzpefR0Y/3t+G0DY5LPsX/WbpZB8BztvJZBMqCSWFEeStUg1nfX81yqYW90VknFAi DyjukWE9rU43BtP5PIO45B4eKHRWvhocFsXTcFsdMqaqif6Pjdv1SGADKY352eoScjJ/ 3jTLb67a8j6E/Ug2o2Q7wuoUj1rqga6xGfdHxqS3ueLAMuciEtAqK+WKb7/8xQ3uY8BN GIF9EkTa/FZosijehVMC1IhQkj0iaoRnrwuy5O3aZ40Yjtmw4zfwPXkUd+rU/UouZGAi UlNKXXx66ZPf7L/inpxwx01ikLI7dHOIc5HraPLBfQT5VmQ06TiPGVc6si/wP1OR/bjW NOPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=zcyEbPSV2KB29tiHkE3SoMNctJ85E2cOIO/447pDHUE=; b=Q/ZiiiWsAPbEz3qpApR/uNh6dH8JqCu3DBE0di6vIuJnE4LzNbjmthQH50ja4J3vaE hGepUmcYw915WcWzwgVrRRV5PsoTnS6sKyvVii3gFoqy1RIDAEqjZMeZT6hqooix0Hoe gVT340xlZa5ppUycWmUCc5CnQtOGDcw6kD80Eno6oFg8eSlMk2E05/Bb53kQQHmOGHJJ qfL5+IeMnzHdEW+WgR86ukrKA0nRBEF3+RH5n/griLjPSXXYeb0iRiQg9lfKN9WckDaw MVvxm7gmln8r/elu/sIWWpWkb905lZzMXY7NnajnbYN9QPuYO/IfjE5RxGJNg2np+Hbr /M0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gu10si6522196ejb.461.2020.05.23.10.30.10; Sat, 23 May 2020 10:30:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387992AbgEWR21 (ORCPT + 99 others); Sat, 23 May 2020 13:28:27 -0400 Received: from mailomta20-re.btinternet.com ([213.120.69.113]:15347 "EHLO re-prd-fep-048.btinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387507AbgEWR20 (ORCPT ); Sat, 23 May 2020 13:28:26 -0400 Received: from re-prd-rgout-003.btmx-prd.synchronoss.net ([10.2.54.6]) by re-prd-fep-048.btinternet.com with ESMTP id <20200523172824.MQWV4003.re-prd-fep-048.btinternet.com@re-prd-rgout-003.btmx-prd.synchronoss.net>; Sat, 23 May 2020 18:28:24 +0100 Authentication-Results: btinternet.com; auth=pass (LOGIN) smtp.auth=j.oldman998@btinternet.com X-Originating-IP: [31.53.141.224] X-OWM-Source-IP: 31.53.141.224 (GB) X-OWM-Env-Sender: j.oldman998@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgeduhedrudduhedguddufecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucenucfjughrpefhvffufffkofestddtredtredttdenucfhrhhomheplfhohhhnucfqlhgumhgrnhcuoehjohhhnhdrohhlughmrghnsehpohhlvghhihhllhdrtghordhukheqnecuggftrfgrthhtvghrnhepgeeftdfhfeeuiefhgfekfeethedutddtfeduteevleevfedvfefhjeeijefhgffgnecukfhppeefuddrheefrddugedurddvvdegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghlohephhgvnhhrhidrhhhomhgvpdhinhgvthepfedurdehfedrudeguddrvddvgedpmhgrihhlfhhrohhmpeeojhhohhhnrdholhgumhgrnhesphholhgvhhhilhhlrdgtohdruhhkqedprhgtphhtthhopeeouggvvhgvlhesughrihhvvghruggvvhdrohhsuhhoshhlrdhorhhgqedprhgtphhtthhopeeoghhrvghgkhhhsehlihhnuhigfhhouhhnuggrthhiohhnrdhorhhgqedprhgtphhtthhopeeojhhohhhnrdholhgumhgrnhesphholhgvhhhilhhlrdgtohdruhhkqedprhgtphhtthhopeeolhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgqe X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from henry.home (31.53.141.224) by re-prd-rgout-003.btmx-prd.synchronoss.net (5.8.340) (authenticated as j.oldman998@btinternet.com) id 5EC3CE9B00C78F15; Sat, 23 May 2020 18:28:24 +0100 From: John Oldman To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, John Oldman Subject: [PATCH] staging: rtl8192e: Using comparison to true is error prone Date: Sat, 23 May 2020 18:28:12 +0100 Message-Id: <20200523172812.16473-1-john.oldman@polehill.co.uk> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clear below issues reported by checkpatch.pl: CHECK: Using comparison to false is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index d83d72594312..8abc921ecb3e 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -371,7 +371,7 @@ void HTConstructInfoElement(struct rtllib_device *ieee, u8 *posHTInfo, if ((ieee->iw_mode == IW_MODE_ADHOC) || (ieee->iw_mode == IW_MODE_MASTER)) { pHTInfoEle->ControlChl = ieee->current_network.channel; - pHTInfoEle->ExtChlOffset = ((pHT->bRegBW40MHz == false) ? + pHTInfoEle->ExtChlOffset = ((!pHT->bRegBW40MHz) ? HT_EXTCHNL_OFFSET_NO_EXT : (ieee->current_network.channel <= 6) ? HT_EXTCHNL_OFFSET_UPPER : @@ -526,7 +526,7 @@ void HTOnAssocRsp(struct rtllib_device *ieee) static u8 EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33}; static u8 EWC11NHTInfo[] = {0x00, 0x90, 0x4c, 0x34}; - if (pHTInfo->bCurrentHTSupport == false) { + if (!pHTInfo->bCurrentHTSupport) { netdev_warn(ieee->dev, "%s(): HT_DISABLE\n", __func__); return; } @@ -873,7 +873,7 @@ void HTSetConnectBwMode(struct rtllib_device *ieee, { struct rt_hi_throughput *pHTInfo = ieee->pHTInfo; - if (pHTInfo->bRegBW40MHz == false) + if (!pHTInfo->bRegBW40MHz) return; if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev)) -- 2.17.1