Received: by 2002:a25:d80d:0:0:0:0:0 with SMTP id p13csp180054ybg; Sat, 23 May 2020 10:48:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvBoCKLnVEcl/uz+CfEwIumvR4gjGFlH82F0F2QQ9lJfxlxJjb+O2It3iMpbx3vT2wgX4J X-Received: by 2002:a05:6402:2058:: with SMTP id bc24mr8112977edb.134.1590256108095; Sat, 23 May 2020 10:48:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590256108; cv=none; d=google.com; s=arc-20160816; b=QATlx5CXy4HjDa5CkILbwa+l79sroIkqOidfW+YUGEqImuQqpPXMYHCFTldfmA019p kkjj6CuM4tBs2eUvct1wjZGg5QKneT5P/yDTmrwVnBQDd21atap/WOtDZ34A00GgLG+z H+Prk+8yCcF3wVPl0v4/ybV5923NBZdRIK7I/8GOAE4cPXz8mmzWE8SazVQaLwM7/jZj DQRGmZ3DT+ENy9FYR0bIwsMh/tah/yIZc0rv1y6EW3jkSmS+eGuVkUcfyfuw7H99yApS WWHKmMoFXObo3fKKidsbHIFJjtvaXbX8nUXVFgIrcG+0Wipl+2UxPFZ4IUib3tkFDeA9 G/vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=hmVNOLK3bKFXHmjFp9am5qP1EggAj55HA0bMfEG3OVc=; b=XvqD1f9ZHkQdI8IAjI+kur48COFbLWz4YL/HMVHAmB7+PYWoPAxA1VldQCr9UCdo6X DiortQJbj3mG6z0UnGc/y3zxprvi+kh/6Xa7AZvn8/qJYaqJr3HBz8RdGmDrcYSGjwAr 7I5SAy+LG9Wj/1k05erqyzwkqKUfPMSa0g8Tjlaw6QrbyQUurxcSbNl8ZgqnhirkXm+j jShgipljDYqARSWuvInQa5e3wymkJreXZzC3uw/dIASAjEraAgowBJR2srakplq9ojaS GdRTlB9O7cWbChBdcrMPGKUqIjN0JdNxFcPbRZ1/IQ5FLAcbzcTYW9iLzylrqpbJ613L Y50Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a17si6286822edj.251.2020.05.23.10.48.05; Sat, 23 May 2020 10:48:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387992AbgEWRob (ORCPT + 99 others); Sat, 23 May 2020 13:44:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387515AbgEWRoa (ORCPT ); Sat, 23 May 2020 13:44:30 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84252C061A0E for ; Sat, 23 May 2020 10:44:30 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jcYBo-0004nX-LL; Sat, 23 May 2020 19:44:04 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1jcYBl-0005dS-0l; Sat, 23 May 2020 19:44:01 +0200 Date: Sat, 23 May 2020 19:44:00 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Yangtao Li , thierry.reding@gmail.com Cc: claudiu.beznea@microchip.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, f.fainelli@gmail.com, nsaenzjulienne@suse.de, shc_work@mail.ru, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, vz@mleia.com, slemieux.tyco@gmail.com, khilman@baylibre.com, matthias.bgg@gmail.com, heiko@sntech.de, palmer@dabbelt.com, paul.walmsley@sifive.com, mripard@kernel.org, wens@csie.org, jonathanh@nvidia.com, linux@prisktech.co.nz, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH 30/32] pwm: hibvt: do some cleanup Message-ID: <20200523174400.tzptmraqyn3uqrvf@pengutronix.de> References: <20191229080610.7597-1-tiny.windzz@gmail.com> <20191229080610.7597-30-tiny.windzz@gmail.com> <20200220204152.p6rublsssifvvnvk@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200220204152.p6rublsssifvvnvk@pengutronix.de> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 20, 2020 at 09:41:52PM +0100, Uwe Kleine-K?nig wrote: > On Sun, Dec 29, 2019 at 08:06:08AM +0000, Yangtao Li wrote: > > Use devm_platform_ioremap_resource() to simplify code. > > 'i' and 'ret' are variables of the same type and there is no > > need to use two lines. > > I think I wouldn't have merged these two lines, but I don't feel strong > here. The other 31 patches are clean replacements. > > But I also don't think respining just for this minor thing is worth the > effort, so: > > Acked-by: Uwe Kleine-K?nig > > for the whole series. (Not sure it is sensible to ack each patch > individually, @Thierry, tell me if this simplifies things for you.) I took a deeper look now and added Reviewed-by for all other patches to ease application. So doing the same here: Reviewed-by: Uwe Kleine-K?nig FTR: I'd do the following now: for patch in 1216003 1216065 1216063 1216005 1216062 1216061 1216059 1216057 1216054 1216056 1216051 1216050 1216048 1216010 1216044 1216046 1216042 1216041 1216036 1216037 1216034 1216032 1216030 1216013 1216029 1216025 1216026 1216024 1216015 1216021 1216017 1216019; do pwclient git-am -m -s $patch && pwclient update -s "Accepted" -c "$(git rev-parse HEAD)" $patch || break done Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | https://www.pengutronix.de/ |