Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] linux/blkdev.h: Use ilog2() directly in blksize_bits()
To:     Bart Van Assche <bvanassche@acm.org>,
        Kaitao Cheng <pilgrimtao@gmail.com>
Cc:     damien.lemoal@wdc.com, ming.lei@redhat.com,
        martin.petersen@oracle.com, satyat@google.com,
        chaitanya.kulkarni@wdc.com, houtao1@huawei.com,
        asml.silence@gmail.com, ajay.joshi@wdc.com,
        linux-kernel@vger.kernel.org, songmuchun@bytedance.com
References: <20200523155048.29369-1-pilgrimtao@gmail.com>
 <714861ac-50aa-465c-c28f-dce7e16d0313@acm.org>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <fd3b8124-d62b-ca73-5af2-0d2ee2c58f92@kernel.dk>
Date:   Sat, 23 May 2020 12:50:03 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <714861ac-50aa-465c-c28f-dce7e16d0313@acm.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 5/23/20 12:33 PM, Bart Van Assche wrote:
> On 2020-05-23 08:50, Kaitao Cheng wrote:
>> blksize_bits() can be achieved through ilog2(), and ilog2() is
>> more efficient.
> 
> If Jens agrees, how about removing the blksize_bits() function entirely
> and to make all callers use ilog2() instead of blksize_bits()?

Yeah, if we are going this path, then let's just kill the function
completely.

-- 
Jens Axboe