Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] fpga: dfl: afu: convert get_user_pages() -->
 pin_user_pages()
To:     Moritz Fischer <mdf@kernel.org>
CC:     LKML <linux-kernel@vger.kernel.org>, Xu Yilun <yilun.xu@intel.com>,
        Wu Hao <hao.wu@intel.com>, <linux-fpga@vger.kernel.org>
References: <20200519201449.3136033-1-jhubbard@nvidia.com>
 <64aa1494-7570-5319-b096-ea354ff20431@nvidia.com>
 <20200523205717.GA443638@epycbox.lan>
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <ccf86d21-2ecf-7873-1c30-fbea880b9081@nvidia.com>
Date:   Sat, 23 May 2020 14:33:12 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200523205717.GA443638@epycbox.lan>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-05-23 13:57, Moritz Fischer wrote:
> On Fri, May 22, 2020 at 06:52:34PM -0700, John Hubbard wrote:
>> On 2020-05-19 13:14, John Hubbard wrote:
>>> This code was using get_user_pages_fast(), in a "Case 2" scenario
>>> (DMA/RDMA), using the categorization from [1]. That means that it's
>>> time to convert the get_user_pages_fast() + put_page() calls to
>>> pin_user_pages_fast() + unpin_user_pages() calls.
>>>
>>> There is some helpful background in [2]: basically, this is a small
>>> part of fixing a long-standing disconnect between pinning pages, and
>>> file systems' use of those pages.
>>>
>>> [1] Documentation/core-api/pin_user_pages.rst
>>>
>>> [2] "Explicit pinning of user-space pages":
>>>       https://lwn.net/Articles/807108/
>>>
>>> Cc: Xu Yilun <yilun.xu@intel.com>
>>> Cc: Wu Hao <hao.wu@intel.com>
>>> Cc: Moritz Fischer <mdf@kernel.org>
>>> Cc: linux-fpga@vger.kernel.org
>>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
>>
>>
>> Hi Moritz and FPGA developers,
>>
>> Is this OK? And if so, is it going into your git tree? Or should I
>> send it up through a different tree? (I'm new to the FPGA development
>> model).
> 
> I can take it, sorry for sluggish response.
> 

That's great news, thanks Moritz! Sorry to be pushy, just didn't want it
to get lost. :)

thanks,
-- 
John Hubbard
NVIDIA