Received: by 2002:a25:d80d:0:0:0:0:0 with SMTP id p13csp320184ybg;
        Sat, 23 May 2020 15:37:14 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwKcWyq2m/N4/rm0C3XTI5z6KJPm519/h86g1LdTDEwN7CebKh3yXovPDEjR1LSh2neBA5R
X-Received: by 2002:a17:906:f891:: with SMTP id lg17mr12988413ejb.405.1590273434328;
        Sat, 23 May 2020 15:37:14 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1590273434; cv=none;
        d=google.com; s=arc-20160816;
        b=rGu2pMjWufUGYFCJ8uuYDKIYNm0YleweAXLNWOieVq5ia7r1fenOGmbrWsvljDvURA
         ehQ2tfdbUPt2PDB0JVMwBQ8x8Or8TTuAjQWXie4pq3OJ3Y45ggCTsozOkMy06WcA+/kV
         amh88yC0oTebzNZQvLPmArvZmN858FR1qfEtvX/HFGBeNstVpwXhA4WVu1E/YbDkGSQN
         7Y8WB6tvzN8Yr+J1hSroCQkaVRhqC+6umt9MrqWsD+IR2ivgsMX7ioLdMgryi0abPdbi
         fHfQDkyHLeZWRIgqaw0CbR+knQeg0dJR4q5Hm7UR2bPOd1kFfXxjucylwS42YcqWMqnd
         Nt9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=Dj1279TCnkN87o3nCDTP/1pcxnVBWshZf4YWt7psSsI=;
        b=nxQz4iS/n6mCxSX7hs5qyjieZ+lw+HMEpj1LMjpZESLME+NelCDua7tT85uBT5X5lN
         NSgVXUn0EvCTL3G/hranCfYRwP63UgSPnf61RAOhBZMaHC/y5Qy4PfyiB2a4KbcoczYF
         iifulkB/L5r71NzOQkIozed2fDfFHvfH1Zfsu1IFr5gF2LQHEHmVPVDvjsVS4N8k6Uw4
         pICU83tmaFtFJbuyQs9pFO7epd/DIv2kM6GeL3nNbk1pQLDsmpXPMVlBK7ZM/QbBEx0Z
         4O9CpMrJCN6JJ2soZDZ05BnK/CGdJn7OyaUVO0QzxWle2hsUsOvC/Syjp/trdIWbtMNc
         Xdnw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id gl8si7188724ejb.149.2020.05.23.15.36.36;
        Sat, 23 May 2020 15:37:14 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2388042AbgEWWdt (ORCPT <rfc822;chenl.lei@gmail.com> + 99 others);
        Sat, 23 May 2020 18:33:49 -0400
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:2282 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728414AbgEWWds (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 23 May 2020 18:33:48 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5ec9a4c00000>; Sat, 23 May 2020 15:33:36 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Sat, 23 May 2020 15:33:48 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Sat, 23 May 2020 15:33:48 -0700
Received: from [10.2.58.199] (172.20.13.39) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 23 May
 2020 22:33:48 +0000
Subject: Re: [PATCH v2 0/4] mm/gup, drm/i915: refactor gup_fast, convert to
 pin_user_pages()
To:     Chris Wilson <chris@chris-wilson.co.uk>,
        Andrew Morton <akpm@linux-foundation.org>
CC:     Souptick Joarder <jrdr.linux@gmail.com>,
        Matthew Wilcox <willy@infradead.org>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
        Matthew Auld <matthew.auld@intel.com>,
        <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
References: <20200522051931.54191-1-jhubbard@nvidia.com>
 <159022688563.11139.3402294435382936623@build.alporthouse.com>
From:   John Hubbard <jhubbard@nvidia.com>
X-Nvconfidentiality: public
Message-ID: <d87cdee8-aa0f-91ca-ea86-e89c4536458f@nvidia.com>
Date:   Sat, 23 May 2020 15:33:47 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <159022688563.11139.3402294435382936623@build.alporthouse.com>
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2020-05-23 02:41, Chris Wilson wrote:
> Quoting John Hubbard (2020-05-22 06:19:27)
>> The purpose of posting this series is to launch a test in the
>> intel-gfx-ci tree. (The patches have already been merged into Andrew's
>> linux-mm tree.)
>>
>> This applies to today's linux.git (note the base-commit tag at the
>> bottom).
>>
>> Changes since V1:
>>
>> * Fixed a bug in the refactoring patch: added FOLL_FAST_ONLY to the
>>    list of gup_flags *not* to WARN() on. This lead to a failure in the
>>    first intel-gfx-ci test run [1].
>>
>> [1] https://lore.kernel.org/r/159008745422.32320.5724805750977048669@build.alporthouse.com
> 
> Ran this through our CI, warn and subsequent lockup were gone. That
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
	t=1590273216; bh=oK85oUq4LCrgTs8kxvJryKE7a7GUQfAveFtGpNOU2dQ=;
	h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality:
	 Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
	 X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
	 Content-Transfer-Encoding;
	b=QoI4eJbYYVxcoARKgFJdRrxzB/GBPqy5yKIF46/pjR75LEiZvvAX947VBwywSMYhx
	 It8aQpMm6kMaF/rxiv0IPBf3tNGxNziWBAAhDXCyNqmvAS5s1HfdQh5ZoYbyDynKbJ
	 uF+u9JjBOYo5uTnn3IUaGPRgl/p9k6OhwRhbJ9nYreDwIF1/1pPeo97jwP2jW7AtDf
	 xDO5iJhGmwLYHPzRLilgiDdLbNhIGAP1XJ/4t/DByshidOUalduU7HxVQ9IOnysnCw
	 QcqSlpyPgx5LkJOvs63gO8n28hHJnoJ4FggNXC3D311lBWRuD7iekdP5WuvmrxUb8N
	 rZKwTpl0vJl9w==


Yea! Thanks again for these test runs. I really don't like posting
patches that I can't run-time test, but this CI system mitigates
that pretty well.


> lockup is worrying me now, but that doesn't seem to be an issue from
> this series.


I do think it's worth following up on. And it seems like it would be
very easy to repro: just hack in a forced failure at the call site of
pin_user_pages_fast_only(), and follow the breadcrumbs.


> 
> The i915 changes were simple enough, I would have computed the pin flags
> just once (since the readonly bit is static, that would be interesting
> if that was allowed to change mid gup :)
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
> 

Thanks for the review! And if lifting that check up higher in the call
stack is desired, I'm all in favor of that being done...in a separate
patch. :)

I'm trying to keep a very light touch when converting these call sites.

thanks,
-- 
John Hubbard
NVIDIA