Received: by 2002:a25:d80d:0:0:0:0:0 with SMTP id p13csp349476ybg;
        Sat, 23 May 2020 16:37:28 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJz4Q7LiqyIQ7RWws3uyrwHYKDzdPveIwgZnlMlfVh27WM3yeGDKSrj9xzYgk2hL2f/LiPo7
X-Received: by 2002:a17:906:63c9:: with SMTP id u9mr13935742ejk.439.1590277048673;
        Sat, 23 May 2020 16:37:28 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1590277048; cv=none;
        d=google.com; s=arc-20160816;
        b=hw9BakTtd1LB89nWVF9wXHAFOVlUE+LjXkicsgzx58+NuNy98V1iRfeSTs8R1omSEt
         aPdX2nXD22rVTYbZyNDfgdVU4Pngv/+YIm12c3GWTJhDRWpvmWbXmefbIs4xudIWAiLG
         gJc6pIQfKXd6kFhQs8Tr+G14pqwH5p44nuvCcrqgFszcj/GhUTO5DRL/f0f63aRHdUu1
         BqtC0RQjlJ2xxRtTw1uZxtvpoYwU8pTrvG1wPp2lqWSM4KBxPgf6hhKR5gNmgV17sKwX
         JjVJkNeYdp6wpVwji/dwCKMkjIaI3Syl5fQidK9Lp2vBPhZo44aZsvnl2/la2zeFXydO
         A+rw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=ZSZxUsMcC9jeatGrAVXDje82iq6vR8evEPynjwZSuNg=;
        b=v4xBAIys8d0yFcnQUnp8GPNjGrmlFOnQUg8GpgTPfuVHwcrKIQbznKbpxOODNuKqtS
         LPaGm2UWpXNCyRAedmTdcaOhi0Pda645o4Tk5reRLCk5tEZbrMVBko3BSHNN1pq90hms
         qDncLLVVcy9fyMIwLHXNhY/ZQvLnFtDET3CEz0WtHaK/MRdNtLDbiuZFPFhe7e9t9uRx
         A7IQw6dDy0BHVxXWhfvuYtyIXIQMCY4pE2yLbq1Etj2xnYPMwZis5ECeYEqnm5cux7ZP
         ERmslqK7nBpyI/Pvk7pMUAC+nzoBWslEmp3SE4R9EvhGBVq8CsvV2+EjMynZehQmnRpu
         W9ow==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id r15si1951897ejx.650.2020.05.23.16.37.05;
        Sat, 23 May 2020 16:37:28 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2388197AbgEWXfW (ORCPT <rfc822;chenl.lei@gmail.com> + 99 others);
        Sat, 23 May 2020 19:35:22 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51398 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2388010AbgEWXfV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 23 May 2020 19:35:21 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2F61C061A0E;
        Sat, 23 May 2020 16:35:21 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id C92821286F3AD;
        Sat, 23 May 2020 16:35:20 -0700 (PDT)
Date:   Sat, 23 May 2020 16:35:19 -0700 (PDT)
Message-Id: <20200523.163519.974222011620661089.davem@davemloft.net>
To:     grygorii.strashko@ti.com
Cc:     kuba@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com,
        linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
        s-anna@ti.com
Subject: Re: [PATCH] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning
 during suspend
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200522163931.29905-1-grygorii.strashko@ti.com>
References: <20200522163931.29905-1-grygorii.strashko@ti.com>
X-Mailer: Mew version 6.8 on Emacs 26.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 23 May 2020 16:35:21 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: Fri, 22 May 2020 19:39:31 +0300

> vlan_for_each() are required to be called with rtnl_lock taken, otherwise
> ASSERT_RTNL() warning will be triggered - which happens now during System
> resume from suspend:
>   cpsw_suspend()
>   |- cpsw_ndo_stop()
>     |- __hw_addr_ref_unsync_dev()
>       |- cpsw_purge_all_mc()
>          |- vlan_for_each()
>             |- ASSERT_RTNL();
> 
> Hence, fix it by surrounding cpsw_ndo_stop() by rtnl_lock/unlock() calls.
> 
> Fixes: 15180eca569b net: ethernet: ti: cpsw: fix vlan mcast
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>

Applied.