Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp416508ybs; Sun, 24 May 2020 09:13:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJ8l1+b3CCWUyIURJfwbbvtp/Z+nwx027rtzdXyWE8NTogu/JiSl4e77wFeEtE9NIq5ZaA X-Received: by 2002:a05:6402:b0b:: with SMTP id bm11mr11967886edb.92.1590336807693; Sun, 24 May 2020 09:13:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590336807; cv=none; d=google.com; s=arc-20160816; b=k1+r4TNQo9M2t75YKj+TineK4PmNC/hjN2yqHgoVxSbxhaVYSv7m+rnheqWe2WntQr OwuktROi+plJELpZOsddpRToAX8s2TcvNLa+1IJwVHAtvgPUfr84Sk6ZrebpK1e5EEu/ eQmZXnkpvUpUqTBlnYu8gEWVSiMMJm4WxL/OYXVo2byacKGfZYI3hEEyWdtkKfFR6E+N vbPbDVfxej80IEXv1PbqVYBwialpMCiZsBPpgagvTEYWKB8A+1OzgiAR/jGSt2HVDJVm sMaVPsaYb9I1P/XfLt3K8e/MX/DP+x8E3uM9YslFtMSzNPJP3vKEBCtSSHHt9DmUk5d9 UOoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=G4dTby7NZmNakzGoZjeQlLs0H6G0vkozS3BnA1yW6Rw=; b=lGuGLq2YyBvE3H58VQuT4UcQF4vNJyulDbzYOWAGLwe/Zr+avMWI90ZlV+sn0KjIT5 /DQqicffEiaMBQf2whn07IeG6476VgtdGJsR0aMr+IGAgiw57ZxGJQuEWBa5mhaSx5dF dToaYZSbEqh5LOKnF9l1ZiT+EZJOhAqyBKu3in2yCkpiOTSHdCEy4hLFLm77MGpcCphx VCysBXetyorFqGCnzpwgpeL75vMbUOoCdPO3OLtNTYZ+jhDgoYTEKBYG++lQtYIqG56T +9JXKW4kC1Bo1CsmRb5c/dueyVBqVR1anEnUyzO+eehLyE2ZIgxYOjU3XCJoGS9mHlgX zNNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm26si2419522edb.266.2020.05.24.09.13.05; Sun, 24 May 2020 09:13:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728508AbgEXQKp (ORCPT + 99 others); Sun, 24 May 2020 12:10:45 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:39352 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727823AbgEXQKp (ORCPT ); Sun, 24 May 2020 12:10:45 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jctD1-0007Av-Bf; Sun, 24 May 2020 16:10:43 +0000 From: Colin King To: Jens Axboe , linux-block@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] loop: remove redundant assignment to variable error Date: Sun, 24 May 2020 17:10:43 +0100 Message-Id: <20200524161043.20292-1-colin.king@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The variable error is being assigned a value that is never read so the assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/block/loop.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index c20d01c08e5c..060da16b3743 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -1136,8 +1136,6 @@ static int loop_configure(struct loop_device *lo, fmode_t mode, if (error) goto out_unlock; - error = 0; - set_device_ro(bdev, (lo->lo_flags & LO_FLAGS_READ_ONLY) != 0); lo->use_dio = lo->lo_flags & LO_FLAGS_DIRECT_IO; -- 2.25.1