Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752490AbWCQCJu (ORCPT ); Thu, 16 Mar 2006 21:09:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752487AbWCQCJu (ORCPT ); Thu, 16 Mar 2006 21:09:50 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:44727 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1752481AbWCQCJt (ORCPT ); Thu, 16 Mar 2006 21:09:49 -0500 Date: Fri, 17 Mar 2006 02:09:42 +0000 From: Christoph Hellwig To: Dimitri Sivanich Cc: Linus Torvalds , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Christoph Lameter , Jes Sorensen Subject: Re: [PATCH] Add SA_PERCPU_IRQ flag support Message-ID: <20060317020942.GA20227@infradead.org> Mail-Followup-To: Christoph Hellwig , Dimitri Sivanich , Linus Torvalds , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Lameter , Jes Sorensen References: <20060317003114.GA1735@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060317003114.GA1735@sgi.com> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1105 Lines: 27 On Thu, Mar 16, 2006 at 06:31:14PM -0600, Dimitri Sivanich wrote: > The generic request_irq/setup_irq code should support the SA_PERCPU_IRQ flag. > > Not sure why it was left out, but this patch adds that support. > > Signed-off-by: Dimitri Sivanich > > Index: linux/kernel/irq/manage.c > =================================================================== > --- linux.orig/kernel/irq/manage.c 2006-03-16 14:05:27.957927445 -0600 > +++ linux/kernel/irq/manage.c 2006-03-16 14:06:02.283661867 -0600 > @@ -201,6 +201,9 @@ int setup_irq(unsigned int irq, struct i > * The following block of code has to be executed atomically > */ > spin_lock_irqsave(&desc->lock,flags); > + if (new->flags & SA_PERCPU_IRQ) { > + desc->status |= IRQ_PER_CPU; > + } looks good, although the braces aren't really needed for single-line conditionals. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/