Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp508448ybs; Sun, 24 May 2020 12:06:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZmSP4iDCUoZxVLSSq1fAObRbH0k2bmKAQNFoNYEdiN/CwMysGb7hwqM/aPMv8eQBRSYFm X-Received: by 2002:a17:907:2046:: with SMTP id pg6mr16757293ejb.95.1590347191818; Sun, 24 May 2020 12:06:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590347191; cv=none; d=google.com; s=arc-20160816; b=QehCONTBcOhyVA5+FdlJTiqPqajsg/Hk27tMO7KqL0lcmaQtRuhBJgmegmuQi9Vog7 6b2/CAI7OZ5EjDDUuuKykwl9Kwb+ohXs570fyTNt4Mod7zHqe/LzKD/Mcobe1d6m9sBE OaTxibaBK7WfhyifIfGFNFvph4o0L8N3N/R2G1WW0QFhGRqnG6+YR+YLH/vuMN4iA+vt SqfansOUqUGbGbZP7upURWKDugYtomjZs3Clq9OUksNT8/391uiG6LC4GpjC4UZjc76w 3Y3L2Cl2yMAuxIIknAtTPJ5eQ2+QC9yY4cwp6GZ0HBW/TZkyMKIFQEbpg/QkxG7Nmm/G 0gSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=vvvMS6ANXCoV8CkajITqzIE6LEBxjb38qUm0b+E/XfE=; b=I8eNe/T/Hcii3tDhKS8f01erdceBqr0NiiFGX6bRGu6mtaOiV2a5OI7PjC3MpzRnfO nRgSRGkzBFxePr9nnOmYqximAxex8h0N3xB2X1ZLclROST0m8wKhIA4zjExSs8mVf0sV 7Rq6r3TPmMZTn1gKULr5blEwOepTSMgjraSonRg683IfCtqGndGfDEk+cy5XFf+oBUpz YKE0Muik5cARUKAMU3yIW96VPq4UQc1C5W8jrlj5iMWWrhCemWUP2HsrDv7J++VxRzZO YttuvGBSl4mzbrP8MQEZP23M+2mRNPGe/wmqt/zU/QX0wIdTxzFOhcCs3nNcvH6ICw9C JXVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TuUTZ9su; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h1si8317014ejl.434.2020.05.24.12.06.08; Sun, 24 May 2020 12:06:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TuUTZ9su; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388099AbgEXTD3 (ORCPT + 99 others); Sun, 24 May 2020 15:03:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:44302 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388085AbgEXTD3 (ORCPT ); Sun, 24 May 2020 15:03:29 -0400 Received: from [192.168.0.50] (89-70-52-201.dynamic.chello.pl [89.70.52.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7BF6E2076C; Sun, 24 May 2020 19:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590347008; bh=Mq59j8ehq3CwHIvV0e9bLb39zHdc2gtg/vFQ35A74Xc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=TuUTZ9suN+FFAN3w+WA2Bkdzw0y7tuhWEIUHtcnflF7x0lao+v5s+KRhz07qfY6F9 hRcbcOS/amhv1LcGlUX1ABdQHcG1aZH5PTuV4uVNvAA+j3dqhj4EJ0O65upC8TjvAM Mb+47d7mJ1+nVlnjEwNJGay6wrujIW/9m1Ah+q34= Subject: Re: [PATCH V2] media: s3c-camif: fix missing disable in tegra_adma_probe(). To: wu000273@umn.edu Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kjlu@umn.edu References: <20200524034616.31625-1-wu000273@umn.edu> From: Sylwester Nawrocki Message-ID: <9b1cdd76-1fbf-c66b-a8e1-929ce2aba791@kernel.org> Date: Sun, 24 May 2020 21:03:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200524034616.31625-1-wu000273@umn.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 5/24/20 05:46, wu000273@umn.edu wrote: > From: Qiushi Wu > > "pm_runtime_enable()" was not handled by "pm_runtime_disable()" > after a call of the function “pm_runtime_get_sync()” failed. > Thus move the jump target “err_pm” before calling function > "calling pm_runtime_disable()". > > Fixes: babde1c243b2 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface") > Signed-off-by: Qiushi Wu > --- > > V2: improving commit messages. Thanks for the patch. It seems you have got typo in the subject line. With tegra_adma_probe changed to s3c_camif_probe feel free to add: Reviewed-by: Sylwester Nawrocki