Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp515326ybs; Sun, 24 May 2020 12:19:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMPywNxaIGMb5EnepXCfZDnCjEsgKo0VHZsbPwC4UKT4KEyilGvaCv/NAWDJW4iJahBvQf X-Received: by 2002:a17:906:8514:: with SMTP id i20mr15349660ejx.298.1590347954710; Sun, 24 May 2020 12:19:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590347954; cv=none; d=google.com; s=arc-20160816; b=rESw8deMWx+EV5Bg6MICU8gpPz/oOva28PEvB8x+RB3xoCuBHU3qZQkdeKyTz0Xf4F dieLW2qFpQmCoSiRVN3M8O5K4Eni8dahBGjV3wgN4wOwwDf3+tt9UhM1odBCRCK3w3d6 e/9hOiQrqBPUztZBI1fHJ3LXMeMqCZXKxLWOKh9HOvMvzBxlhEhf51MJmQjuQ4s5f7eZ 5cLovlMbuHzSo/siTjOdki+2IQob2Fkif7smoKs7YGjk1cT3btxQ+6Y6xT/HXqs/YNjo 9KoMNxYYHZNTfY/AlZLeUVnPEKbyURnFbsAR4CAXD9ntqlwBnRuX3erfAmXvdsBacLL/ cuqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from; bh=l5+1MAz5i/4IGr6w8RideWUWT3qXRJp4G+cLjTFTIUE=; b=VrHHDdUI0OlVq4kMwoqB9mXzgFKlPeehpYXjLh044DKYfU4jGy2DNtkL4qSs0QHAwx LShLasjovliR74mUoeORzgh8++//KBQuL9qO3BVnDaVr4WlvbkZBb0mIKLsBKlRh4fyV 1ksvOAS10NntHfagbjDSzr7ygaOMyUf3w2J/nbeuGdChCY4eSPr7cz5L1r+cRCBURo25 ggeKrsS/pmYRWbesjyNaRdHsuy6RG3fePUxBfeHxeIEC9dNXkiTkDy+tJqmd+J33WFqw 6GmV0h3q+z4Pc9lPSmZUV+b4q/5BfBelssrTpRbn7kybMQ4ORNhbMPTg7wHVxD/UWShu 8geQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m15si7253140eje.73.2020.05.24.12.18.51; Sun, 24 May 2020 12:19:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387851AbgEXTRF (ORCPT + 99 others); Sun, 24 May 2020 15:17:05 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:38969 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387744AbgEXTRF (ORCPT ); Sun, 24 May 2020 15:17:05 -0400 X-Originating-IP: 91.224.148.103 Received: from localhost.localdomain (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 29EA3240002; Sun, 24 May 2020 19:16:59 +0000 (UTC) From: Miquel Raynal To: =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= , computersforpeace@gmail.com, kdasu.kdev@gmail.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, sumit.semwal@linaro.org, linux-mtd@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH v4] mtd: rawnand: brcmnand: correctly verify erased pages Date: Sun, 24 May 2020 21:16:58 +0200 Message-Id: <20200524191658.29742-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200512082451.771212-1-noltari@gmail.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: dcb351c03f2fa6a599de1061b174167e03ee312b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-05-12 at 08:24:51 UTC, =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= wrote: > The current code checks that the whole OOB area is erased. > This is a problem when JFFS2 cleanmarkers are added to the OOB, since it will > fail due to the usable OOB bytes not being 0xff. > Correct this by only checking that data and ECC bytes aren't 0xff. > > Fixes: 02b88eea9f9c ("mtd: brcmnand: Add check for erased page bitflips") > Signed-off-by: Álvaro Fernández Rojas Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel