Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp519342ybs; Sun, 24 May 2020 12:27:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysZ4h9/U65TblrAb/EucC47VujCjLiH43tE2n4Y8b3R6V/dbplEI7AFXm82IbotCCw46b+ X-Received: by 2002:a17:906:6d10:: with SMTP id m16mr15829466ejr.84.1590348456759; Sun, 24 May 2020 12:27:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590348456; cv=none; d=google.com; s=arc-20160816; b=ok4Wqn8NB2eLygNtred5BsEjNNpUghelROzRC8wuNkOZNOreez79UgkeeRrVdYx5mB p1XalkUpjkWjfJUA9cTIa1pKOBxvv81aCbb1oFm7aZAQmIAsjv71TblQ3QXZBdBfBcZS 8Zvi9HW2eeop+1ahe9DiJMfoqYmXXW+BVnmKMvCXxqawUgzhYTgwJlq2N/3ZMi/FxkAw vDbF3XcC3Cm7sGd+eniOcMjDePFUs3CfLcQBoAfJA/Byne01jzbPCLWkobMtwdpPGjoN 4hSfgiFUDEfGdQEGn/A8iter1th3TLxqFVQ39CyVgfhxNltkWVEeI2UcVkR0nllaQvmH Os4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=XhMEpClAt+PfIQ8hr+BTzgcAeLpej4vtVsIBoCgk0eo=; b=xWFlUDkjLrzqJVxpqIsrHTNkHb7ea2WDifqWhQ29PKBuvtfC7s0WeYmzkXHJK0atLo fqhynluomZotEEVDN3iyD5YVgD0VjvLWiJ+8cuK11/mhdq/n0jHoUm3hfbBF8YOnPcN0 GvFjYAp0KCCOdmgf/tuHXznLmNNL5uu/JtIWwJ/o+umVl2tXJo7V0DjzRknfmNZiEBVt A/zgjl4A+9mOMczlE/xbfcz47PzyQdALsLpWNoDZlFSjI8LGUxION3BpIDgBxJ4OQpK/ S91Ek2pGcY5KGLWr1CNX5mOkK92kHf9dX5t9OAquYKIavqa5mOdBTd4gsv0At4KALDg/ JCtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fnypOXGv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r21si7873266edo.391.2020.05.24.12.27.14; Sun, 24 May 2020 12:27:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fnypOXGv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388119AbgEXTZb (ORCPT + 99 others); Sun, 24 May 2020 15:25:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387807AbgEXTZa (ORCPT ); Sun, 24 May 2020 15:25:30 -0400 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C005C08C5C0 for ; Sun, 24 May 2020 12:25:30 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id x22so9383752lfd.4 for ; Sun, 24 May 2020 12:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=XhMEpClAt+PfIQ8hr+BTzgcAeLpej4vtVsIBoCgk0eo=; b=fnypOXGv7rlaol6AuYJkXTQLV72KGeSUudg5L4No9mxAlzpJ3C6XqiaKk7aRKPYA7O 8q4zXDIoYp6A8Um2W7XAw72Oi+JRFwF5pyayBOOWj4CaHqLkPq1poPE5+6b5p6CKdJHP 1sWnJM1+g4ef+VYkH2HmR7X7LuAOTv5WENIVS9NkZVX/76PaL0f+pamQBDOkZSyV7H90 /z+9SgJU5CQxLkelbL4KwR6DG58MoGvsNAxEd2CrYhv4SdMLK0psA1+QfF4a7grKoVOL Yw1199ehj7j95er4PtLXRPTc2BgOWgePZvxkwGX3bIJttyKlrNE2qTrdLezs6wUUIHJc k8AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=XhMEpClAt+PfIQ8hr+BTzgcAeLpej4vtVsIBoCgk0eo=; b=iDdf+2COrf/tZ1imZGNfWH7ktJg98U5hlJAZbBfKeZ8wOYNzeqYFrRNph7Uqt9vWNv e1Wo2iQkVj0gPpNlmJcOmyjAVPlmz6dSA3EnRsIHA38IzBs2F7HhHwN5Lf8wqQp595R8 ZAgq2I+Zhr0RKPAwute+rks7aJFfJPxtVbEpXrsLHw5If9/qZ2hTJMGsysmHmQQev0GX L9T/z207YRSGhMQ9kCF157fqzvEJ8Tf0ayuqBKS4ktJQ9fNqpQqK4MTgIh1ONeGNZiQz POBrkuu/7toRNx9fPcRazTRbtqCHQMlbo4VdBRyujKkM8EddWfQ3yJl2mAIqWLYhMP7m 56ng== X-Gm-Message-State: AOAM530Mg7x/U5sIjaopmWB4zMKWbNEA+dAoyGOClUkwbIQFPeifnYiV hcjGCf0bJ6TdIJ4nUFAjLxK1Ug== X-Received: by 2002:a19:7e15:: with SMTP id z21mr12730265lfc.103.1590348328855; Sun, 24 May 2020 12:25:28 -0700 (PDT) Received: from localhost.localdomain (37-144-159-139.broadband.corbina.ru. [37.144.159.139]) by smtp.googlemail.com with ESMTPSA id v10sm3878137lja.23.2020.05.24.12.25.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2020 12:25:27 -0700 (PDT) From: Andrey Konovalov To: mchehab@kernel.org, sakari.ailus@iki.fi, manivannan.sadhasivam@linaro.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, c.barrett@framos.com, a.brela@framos.com, peter.griffin@linaro.org, Andrey Konovalov Subject: [PATCH v3 00/10] Improvements to IMX290 CMOS driver Date: Sun, 24 May 2020 22:24:55 +0300 Message-Id: <20200524192505.20682-1-andrey.konovalov@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patchset adds improvements to the existing media driver for IMX290 CMOS sensor from Sony. The major changes are adding 2 lane support, configurable link frequency & pixel rate, test pattern generation, and RAW12 mode support. The link frequency & pixel rate combinations depend on various factors like lane count, resolution and image format as per the datasheet. Also fixes for the following issues in the existing driver are included: * the current_format field in the struct imx290 can be used before initialization, * the reset signal to IMX290 isn't handled correctly, * the bus_type field of v4l2_fwnode_endpoint structure passed as the argument to v4l2_fwnode_endpoint_alloc_parse() function is not initiaized. Changes in v3: * The review comments from Sakari are addressed https://lkml.org/lkml/2019/12/19/705 As a part of those changes: . null ptr checks are added to imx290_set_fmt() so that it can be called early in the probe() function to set the default format, and to initialize imx290->current_mode and imx290->bpp - these last two must be set before imx290_calc_pixel_rate() is called when creating the controls . setting imx290->bpp removed from imx290_write_current_format(). Now this function only writes to the camera sensor registers. The call to imx290_write_current_format() is moved from imx290_set_fmt() back to imx290_start_streaming(): imx290_set_fmt() can be called when the sensor is powered off, and writes to the sensor registers would fail. . in imx290_set_ctrl() in the 12 bpp case the value the BLKLEVEL register is restored to when the test pattern is disabled is made consistent with imx290_12bit_settings[] * The "IMX290 sensor driver fixes" patchset included https://patchwork.kernel.org/cover/11407347/ * Added a patch to set the bus_type field of v4l2_fwnode_endpoint structure before calling v4l2_fwnode_endpoint_alloc_parse() Andrey Konovalov (4): media: i2c: imx290: set the format before VIDIOC_SUBDEV_G_FMT is called media: i2c: imx290: fix the order of the args in SET_RUNTIME_PM_OPS() media: i2c: imx290: fix reset GPIO pin handling media: i2c: imx290: set bus_type before calling v4l2_fwnode_endpoint_alloc_parse() Manivannan Sadhasivam (6): media: i2c: imx290: Add support for 2 data lanes media: i2c: imx290: Add configurable link frequency and pixel rate media: i2c: imx290: Add support for test pattern generation media: i2c: imx290: Add RAW12 mode support media: i2c: imx290: Add support to enumerate all frame sizes media: i2c: imx290: Move the settle time delay out of loop drivers/media/i2c/imx290.c | 358 ++++++++++++++++++++++++++++++------- 1 file changed, 297 insertions(+), 61 deletions(-) -- 2.17.1