Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp579578ybs; Sun, 24 May 2020 14:34:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYRJcX7VwB9idYd2BAGbdefHdUw/jYJfjKyGKvwcBlyN/yCJ1u1FlDO09/MQJwY5VVV/2P X-Received: by 2002:a05:6402:14d3:: with SMTP id f19mr12045881edx.135.1590356048688; Sun, 24 May 2020 14:34:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590356048; cv=none; d=google.com; s=arc-20160816; b=BGo0p/rWZ4hKTAVDJcBa9G2IJCrJo56xAy7iWwR/blkshnK9WND+5pv8pTJDfSWpKC RET79vKwbUkX51cUl4Yqc29PNtUWmpHs96zBkVGE/ET62V2HLF5XM19tzaUwryjIweTM A1IH9G1XMJvnJvyqSTNa7CdUnCZuuplvG4HO4Q/Y4/fKC6SZbNBaEIuCS9h7uJEQ3Bqk gNLpVI4ibrJWymMrPtptJYqrHUmqFlYwkuQyUX6YOyxwzvnStPlhcP8IBdQNQcA1XTWE WL5ExuEy3hmt2foWWyv0kxvdjYv4oSXDni8z2Gh0TpHpk2F2dHHn9srXMHtuCHqx1r5X a13g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=S6JwIYvfZKVME/AeA8V/On++nTzRAilw9UNg9BmsvyM=; b=G+354Ke2mj9UX+5eCnTLAB1bCTfKfXHsveNMqBZLGITiKh6euRsQ7yFiStiXNeev6K fFy+zpMLXmTye+sZtCR03CZj2caxvUStBnPeX+31KCg3LeCsOktuKuACTzqVEqlNlmBs vSt6Fjac/6PPPV5KnQO16ILlpl96Y4FEYi60tS6DtynN3pJRvX+UyLkAulsSrrJrJnW+ h6YXzaCSbWZGOYbqbVCufIeb3jUapAYIli+Ada60iYWXd6bFPRif0u8oKHFwMD9r3/Co ghcOsBhmoJdo6CUZEdMLAYdHnEuJezOaE7FBi+BnvoUcaD9vUEzJtnoyaDv6xbiuvW4F 6PqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c26si8778382edn.456.2020.05.24.14.33.46; Sun, 24 May 2020 14:34:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388479AbgEXV27 (ORCPT + 99 others); Sun, 24 May 2020 17:28:59 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:57804 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388451AbgEXV2y (ORCPT ); Sun, 24 May 2020 17:28:54 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id D0DD11C02B1; Sun, 24 May 2020 23:28:52 +0200 (CEST) Date: Sun, 24 May 2020 23:28:51 +0200 From: Pavel Machek To: Daniele Alessandrelli Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Rob Herring , Andy Shevchenko , Paul J Murphy , Arnd Bergmann Subject: Re: [PATCH 1/1] soc: keembay: Add Keem Bay IMR driver Message-ID: <20200524212851.GG1192@bug> References: <13ca92165fab2827b6d439661e75f5b91ef083c2.1587485099.git.daniele.alessandrelli@intel.com> <20200501081002.GA1055721@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > Like I said above, you just broke multi-system kernels by always > > trying > > to do this. Trigger off of a hardware device that only your platform > > has in order to properly load and run. As-is, you don't want to do > > this. > > My bad, I didn't consider the issue of multi-platform ARM kernels. > > The problem is that I need this code to be run early at boot, so I > don't think I can make this a module. How early is early enough? What bootloader are you using? I believe you should simply fix your bootloader not to pass locked memory to the kernel. Alternatively, take that memory off the "memory available" maps, and only re-add it once it is usable. Anything else is dangerous. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html