Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp615776ybs; Sun, 24 May 2020 15:50:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvt3+P+GM+qP0bBwNp2YkSBn/WO3WRl7Gy+BiFcxUr+DGBjf1AcISchnJw0M8XzvkPysMG X-Received: by 2002:aa7:d90b:: with SMTP id a11mr12787088edr.159.1590360640766; Sun, 24 May 2020 15:50:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590360640; cv=none; d=google.com; s=arc-20160816; b=i8fEQiQb27YhBeJ9BH7MRF2yUwIctlaBIBLBWUIW646CyFOv5xLPhWw/OiCGS2D07k Pq+idvmAZS05n1MPNRZZy/0UxN4cIKAhUE9yLGIi8EdGTfs1iNqTQqcPfnmHm5Fkcypm EkZAAo5QlcH3tyaCuSOqmU5yPveqqMPTRyZhmKfSNEZL76x/ommcvlTPnCKCFp2AylLg XuayI6nMn+2vsQOowkEJ84sOESiEt4r9kJD6xmsE7EUmS8Goufs8rXCbjPs79FFkFVX5 UIeYUv4kOHJH2nsS+Vgj+hB1m72eagx6h8CHGuOiE9GVrj0vsZINh4UQz3qu2SLIyFRe 2Xag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=A5cJ+o1sZs04xOUjoznoIZOMy/a3JqYzlg0tEHRElQA=; b=SaVRKk3Rokls0G5aFFqyMfW3lRFhvEeNxeCebBU7h4J2nIHN4aN0vIWPfaBxTrr323 PztWzjQerJqUW2FaYioIjBzGclGvMqcPXYINZT7bDt3+7Axl1icWlSl4Rw4N665boAO1 HeJhqnvMgKtZAG1/bsqUfLpin9iAE6L3US8P0q3DbcKaEgqsDSQXlyBnJVBrzEfAOCKh zR5Jk+5DwxLoM18Jo6JS5SW3hNCXqCV8MhYnLk1IBGar3Hv6NZTR/rMWidbU2qQ4rOwt 8KBrCa75Uvfytam4ghHPSQDTPe3DKWszHz/9YZTwz6CLN86m4UJ7ouO2U3AT0EoQOTol 14uQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r23si8323060edp.515.2020.05.24.15.50.17; Sun, 24 May 2020 15:50:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388319AbgEXWsF (ORCPT + 99 others); Sun, 24 May 2020 18:48:05 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:44489 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387863AbgEXWsF (ORCPT ); Sun, 24 May 2020 18:48:05 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jczPW-00013I-He; Sun, 24 May 2020 22:48:02 +0000 From: Colin King To: Mike Marshall , Martin Brandenburg , devel@lists.orangefs.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] orangefs: remove redundant assignment to variable ret Date: Sun, 24 May 2020 23:48:02 +0100 Message-Id: <20200524224802.27850-1-colin.king@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The variable ret is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- fs/orangefs/orangefs-mod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/orangefs/orangefs-mod.c b/fs/orangefs/orangefs-mod.c index c010c1fddafc..289b648ae196 100644 --- a/fs/orangefs/orangefs-mod.c +++ b/fs/orangefs/orangefs-mod.c @@ -79,7 +79,7 @@ DECLARE_WAIT_QUEUE_HEAD(orangefs_request_list_waitq); static int __init orangefs_init(void) { - int ret = -1; + int ret; __u32 i = 0; if (op_timeout_secs < 0) -- 2.25.1