Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp703747ybs; Sun, 24 May 2020 18:57:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4Cango8AuEbl69JKiI5Y7AEvN2Hz+qh8xTLxV8eJPiQJxCbUunAyP0UdBMuvRktmUX1NM X-Received: by 2002:a17:906:e211:: with SMTP id gf17mr17063176ejb.495.1590371868781; Sun, 24 May 2020 18:57:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590371868; cv=none; d=google.com; s=arc-20160816; b=hkOVkuaX9oxfqjdIPbV7gDkq4qemUKXqbCZgcoY6dBHI9oJ/g+SvBdefzbDi07Droc NRVQ43w1xk2Vs22JOxWF3B8IMgu4g2R0BAuVK8HP99cK8LpZUobVG3AKHiAAcQKI1Mb5 +LuyZnTRNbC19RnO3+PrpS9pwBlmV0dyllz07mchRHYRuBZgZYrmPVzpr8MlBtoCGILh cO8SxlDNB+YAP07W4EGI/nnBtoID0tpFsA1E/yCl1itewZakZ2jyONXdH7SlVg5Z36aI wS4lS9a8vkOEFuSjzAgzU9i51PZXMCqP/rJwXiiYWL8De0uwuPilgIIG9DA+FfUUzbxb d6cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=WgNdEEm9CKkIv8HqkMAg2kmrZY4evhUWZB5s9CtlNLI=; b=HJzilCn8Q/dF/jP/3R+GnF/5KroIGsBqguiRJg7F5Vpk6jVxieivij3o1nyBMJ9ftY QW0m5P4kusC28OCpnHCKxpq/c4WgeCT7aRyIBEAZLHC6Jj/AmXpGdvbkYUFTW/vXwmC9 iDR9F3J5E8oh9qpgNcu3Y1B4RG6Pn0BNXode9PmsTH7KJeGFhJzt+HEtUk5gPsMu53Zo 5Tvwb35VLrODv6owLtJCqhjpTZlvQxcUbk3yecqudurcOxrCGrNLBqyqabr+zJBqeJEq h1Oy7773lVWG/zl3bKSo6/QXjvEi3eXF8KU0QM2jBR8y9gTrdp+B2KwhboWjU9oIw0GJ vtZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@axtens.net header.s=google header.b=IiDAf+dv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o59si9050492eda.39.2020.05.24.18.57.23; Sun, 24 May 2020 18:57:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@axtens.net header.s=google header.b=IiDAf+dv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388401AbgEYBwu (ORCPT + 99 others); Sun, 24 May 2020 21:52:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388054AbgEYBwt (ORCPT ); Sun, 24 May 2020 21:52:49 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44EB8C061A0E for ; Sun, 24 May 2020 18:52:48 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id u22so6889068plq.12 for ; Sun, 24 May 2020 18:52:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=WgNdEEm9CKkIv8HqkMAg2kmrZY4evhUWZB5s9CtlNLI=; b=IiDAf+dvMuve0czUMKQYCts2SBoBFEpkIgWQGTTd2wOSLIJaK19N0xGac9vsPJAdFz Z9DjMFJvgJxMsXZOq71sHrZqBcxDqCjS0HgYHu0Kxm1WtaXWZag1Hb48Q1FE+s2VMqfa UvH3o6pFdIreXxwQYqhya5gRTd4+kNnp5vRgU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=WgNdEEm9CKkIv8HqkMAg2kmrZY4evhUWZB5s9CtlNLI=; b=PrKgBPG54Q9LV7+ecYfia3QsyCdepBJ8FnpngSt3NUfHYbOmwxSp1ZM5gmoxtP97ZJ 0IRlhMy7idxLRhpUvRls08MGPKnYUnICpPGjLS3JlLI25Soq9CnEJ23MoNgU2cnkiTeB QFKl22wzGkwsvbvJ6Go7hwKB5dRVrseCTHEFqLzsx2GUsIXMEF2knrypoL5ss8WL1Y2z 96+hoqNQqFDChruF/pJwJkdZSccaavk1QYFdbDKeZmfMFi6fxb5MVaotZU/2/G9M+gxH pjM5QJrQ73ZXSGPeWnV5KG8+gtHsG/cQWAE9FLKHXAcL7kAzkCCBhWoQRhkPYhgO/2oe sEjQ== X-Gm-Message-State: AOAM531aNCZtyqWCpunN5V0hQdOfkVobiAd+ObJ5GeVd/t3PHfAQoUpx OLHocw0thLzlhRaRPicxBxkp2Q== X-Received: by 2002:a17:902:6b09:: with SMTP id o9mr24576526plk.100.1590371567787; Sun, 24 May 2020 18:52:47 -0700 (PDT) Received: from localhost (2001-44b8-1113-6700-b9bb-eae4-aa7c-e185.static.ipv6.internode.on.net. [2001:44b8:1113:6700:b9bb:eae4:aa7c:e185]) by smtp.gmail.com with ESMTPSA id m15sm10436166pgv.45.2020.05.24.18.52.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2020 18:52:47 -0700 (PDT) From: Daniel Axtens To: Salvatore Bonaccorso , David Rientjes Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, ajd@linux.ibm.com, mpe@ellerman.id.au, syzbot+1e925b4b836afe85a1c6@syzkaller-ppc64.appspotmail.com, syzbot+587b2421926808309d21@syzkaller-ppc64.appspotmail.com, syzbot+58320b7171734bf79d26@syzkaller.appspotmail.com, syzbot+d6074fb08bdb2e010520@syzkaller.appspotmail.com, Guenter Roeck Subject: Re: [PATCH v2] relay: handle alloc_percpu returning NULL in relay_open In-Reply-To: <20200521152514.GA2868125@eldamar.local> References: <20191219121256.26480-1-dja@axtens.net> <20200521152514.GA2868125@eldamar.local> Date: Mon, 25 May 2020 11:52:43 +1000 Message-ID: <87ftbo232s.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> > Check if alloc_percpu returns NULL. >> > >> > This was found by syzkaller both on x86 and powerpc, and the reproducer >> > it found on powerpc is capable of hitting the issue as an unprivileged >> > user. >> > >> > Fixes: 017c59c042d0 ("relay: Use per CPU constructs for the relay channel buffer pointers") >> > Reported-by: syzbot+1e925b4b836afe85a1c6@syzkaller-ppc64.appspotmail.com >> > Reported-by: syzbot+587b2421926808309d21@syzkaller-ppc64.appspotmail.com >> > Reported-by: syzbot+58320b7171734bf79d26@syzkaller.appspotmail.com >> > Reported-by: syzbot+d6074fb08bdb2e010520@syzkaller.appspotmail.com >> > Cc: Akash Goel >> > Cc: Andrew Donnellan # syzkaller-ppc64 >> > Reviewed-by: Michael Ellerman >> > Reviewed-by: Andrew Donnellan >> > Cc: stable@vger.kernel.org # v4.10+ >> > Signed-off-by: Daniel Axtens >> >> Acked-by: David Rientjes > > It looks this one was never applied (which relates to CVE-2019-19462, > as pointed by Guenter in 20191223163610.GA32267@roeck-us.net). > > Whas this lost or are there any issues pending? I'm not aware of any pending issues. (But, if anyone does have any objections I'm happy to revise the patch.) Regards, Daniel