Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: pzA+Xej8jR30BLyJ3+ot7KUZJgJTCMuYKk8Eis02aoVtRu7KqiLOqCjPb/XNOU6je4VwYeY2zB
 SIjAd7JHG4lQ==
IronPort-SDR: gDYKHAOYkqlgCwaaP/c2zfF1dgDOsfr6KryjH0LorQZAhaWgqVSWimpZPXJivcXEWN22KjDDbz
 5cQvKdAMKegw==
Date:   Mon, 25 May 2020 12:14:58 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Wei Yang <richard.weiyang@gmail.com>
Cc:     akpm@linux-foundation.org, christian.brauner@ubuntu.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bitops: simplify get_count_order_long()
Message-ID: <20200525091458.GK1634618@smile.fi.intel.com>
References: <20200524123551.9469-1-richard.weiyang@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200524123551.9469-1-richard.weiyang@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, May 24, 2020 at 12:35:51PM +0000, Wei Yang wrote:
> These two cases could be unified into one.

Care to provide a test case which supports your change?

> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> ---
>  include/linux/bitops.h | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/include/linux/bitops.h b/include/linux/bitops.h
> index 9acf654f0b19..5b5609e81a84 100644
> --- a/include/linux/bitops.h
> +++ b/include/linux/bitops.h
> @@ -206,10 +206,7 @@ static inline int get_count_order_long(unsigned long l)
>  {
>  	if (l == 0UL)
>  		return -1;
> -	else if (l & (l - 1UL))
> -		return (int)fls_long(l);
> -	else
> -		return (int)fls_long(l) - 1;
> +	return (int)fls_long(--l);
>  }

-- 
With Best Regards,
Andy Shevchenko